Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 38 additions & 0 deletions docs/PHOTO-UPLOAD-SMOKE-CHECKLIST.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,38 @@
# Photo Upload — Beta Smoke Checklist

Run on real device (iOS + Android) before beta launch.

## User avatar

- [ ] Open Profile -> tap avatar -> ImagePicker permission requested first time
- [ ] Pick photo from library -> upload starts, progress visible
- [ ] After upload -> avatar refreshes without app restart
- [ ] Restart app -> avatar still loads from S3, not blank
- [ ] Tap avatar again -> replace with new photo -> old object is removed from S3 if backend access is available

## Tutor profile photos

- [ ] In Profile -> tutor section -> upload 4 photos in one session
- [ ] Progress is visible while each photo uploads
- [ ] All 4 appear in profile gallery
- [ ] Reorder and delete one -> UI updates immediately
- [ ] Restart app -> gallery order and contents are unchanged

## Service photos

- [ ] In ServiceWizardScreen, edit existing service -> add photo to service
- [ ] Save -> photo visible in service detail
- [ ] Other user in student role sees photo while browsing service

## Edge cases

- [ ] Slow network simulation on iOS or Android -> upload completes or shows a clear retryable error
- [ ] Kill app mid-upload -> reopen -> no orphan placeholder, upload can be retried
- [ ] Upload 15 MB photo -> app compresses it automatically or rejects it with a friendly message
- [ ] Upload non-image file renamed to `.jpg` -> backend rejects or app shows a clear upload error
- [ ] Two devices on the same user upload simultaneously -> both successful photos are visible after refresh

## Cross-channel

- [ ] After tutor uploads a new photo -> student opens tutor profile -> updated photo is visible
- [ ] Presigned GET/proxy URL remains valid long enough for normal profile browsing
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
"expo-constants": "~18.0.13",
"expo-dev-client": "~6.0.20",
"expo-image": "^3.0.11",
"expo-image-manipulator": "~14.0.8",
"expo-image-picker": "~17.0.10",
"expo-linear-gradient": "^15.0.8",
"expo-localization": "~17.0.8",
Expand Down
12 changes: 12 additions & 0 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

209 changes: 209 additions & 0 deletions src/features/profile/hooks/photoUploadHooks.test.tsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,209 @@
import React from 'react';
import TestRenderer, { act } from 'react-test-renderer';
import { beforeEach, describe, expect, it, vi } from 'vitest';
import { useTutorPhotos } from './useTutorPhotos';
import { useUserAvatar } from './useUserAvatar';

const apiMocks = vi.hoisted(() => ({
getUserAvatar: vi.fn(),
requestUserAvatarUploadUrl: vi.fn(),
upsertUserAvatar: vi.fn(),
getTutorPhotos: vi.fn(),
requestTutorPhotoUploadUrl: vi.fn(),
confirmTutorPhotoUpload: vi.fn(),
deleteTutorPhoto: vi.fn(),
}));

const imagePickerMocks = vi.hoisted(() => ({
requestMediaLibraryPermissionsAsync: vi.fn(),
launchImageLibraryAsync: vi.fn(),
}));

const mediaMocks = vi.hoisted(() => ({
prepareImageForUpload: vi.fn(),
uploadBinaryToStorage: vi.fn(),
}));

const alertMocks = vi.hoisted(() => ({
showAlert: vi.fn(),
}));

const i18nMocks = vi.hoisted(() => ({
t: (key: string) => key,
}));

vi.mock('../../../shared/api/client', () => ({
api: apiMocks,
}));

vi.mock('expo-image-picker', () => imagePickerMocks);

vi.mock('../../../shared/utils/media', () => {
const sortByPosition = <T extends { position?: number | null }>(items: T[]) =>
[...items].sort((left, right) => (left.position ?? 0) - (right.position ?? 0));
return {
prepareImageForUpload: mediaMocks.prepareImageForUpload,
uploadBinaryToStorage: mediaMocks.uploadBinaryToStorage,
resolveMediaUrl: (media?: { proxy_url?: string | null; url?: string | null } | null) =>
media?.proxy_url ?? media?.url ?? null,
sortByPosition,
};
});

vi.mock('../../../shared/utils/alert', () => ({
showAlert: alertMocks.showAlert,
}));

vi.mock('react-i18next', () => ({
useTranslation: () => ({
t: i18nMocks.t,
}),
}));

const pickedAsset = {
uri: 'file:///picked.jpg',
fileName: 'picked.jpg',
mimeType: 'image/jpeg',
fileSize: 1024,
width: 1000,
height: 800,
};

const preparedAsset = {
uri: 'file:///prepared.jpg',
fileName: 'avatar-1.jpg',
contentType: 'image/jpeg',
sizeBytes: 512,
width: 1000,
height: 800,
};

const renderHook = <T,>(hook: () => T) => {
const result = { current: undefined as T | undefined };
const TestComponent = () => {
result.current = hook();
return null;
};
let renderer: TestRenderer.ReactTestRenderer;
act(() => {
renderer = TestRenderer.create(<TestComponent />);
});
return {
result: result as { current: T },
unmount: () => renderer.unmount(),
};
};

const pickImage = () => {
imagePickerMocks.requestMediaLibraryPermissionsAsync.mockResolvedValue({ granted: true });
imagePickerMocks.launchImageLibraryAsync.mockResolvedValue({
canceled: false,
assets: [pickedAsset],
});
};

beforeEach(() => {
vi.clearAllMocks();
pickImage();
mediaMocks.prepareImageForUpload.mockResolvedValue(preparedAsset);
mediaMocks.uploadBinaryToStorage.mockResolvedValue({ sizeBytes: preparedAsset.sizeBytes });
});

describe('photo upload hooks', () => {
it('runs user avatar presign -> upload -> confirm -> refetch', async () => {
apiMocks.getUserAvatar.mockResolvedValue(null);
apiMocks.requestUserAvatarUploadUrl.mockResolvedValue({
upload_url: 'mock-upload://avatar',
storage_key: 'users/1/avatar/photo.jpg',
});
apiMocks.upsertUserAvatar.mockResolvedValue({ id: 10, user_id: 1 });

const { result } = renderHook(() => useUserAvatar(1, true));

await result.current.pickAndUpload();
await act(async () => undefined);

expect(apiMocks.requestUserAvatarUploadUrl).toHaveBeenCalledWith(1, {
contentType: 'image/jpeg',
filename: 'avatar-1.jpg',
});
expect(mediaMocks.uploadBinaryToStorage).toHaveBeenCalledWith(
expect.objectContaining({
uploadUrl: 'mock-upload://avatar',
fileUri: 'file:///prepared.jpg',
contentType: 'image/jpeg',
}),
);
expect(apiMocks.upsertUserAvatar).toHaveBeenCalledWith(
1,
expect.objectContaining({
storage_key: 'users/1/avatar/photo.jpg',
content_type: 'image/jpeg',
size_bytes: 512,
}),
);
expect(apiMocks.getUserAvatar).toHaveBeenCalled();
});

it('shows a friendly avatar error when compression leaves the file too large', async () => {
mediaMocks.prepareImageForUpload.mockRejectedValue(new Error('photo_too_large'));
const { result } = renderHook(() => useUserAvatar(1, false));

await result.current.pickAndUpload();
await act(async () => undefined);

expect(apiMocks.requestUserAvatarUploadUrl).not.toHaveBeenCalled();
expect(alertMocks.showAlert).toHaveBeenCalledWith('errorTitle', 'photoUploadTooLarge');
});

it('runs tutor photo upload and refetches the list', async () => {
apiMocks.getTutorPhotos.mockResolvedValue([]);
apiMocks.requestTutorPhotoUploadUrl.mockResolvedValue({
upload_url: 'mock-upload://tutor',
storage_key: 'tutors/7/photo.jpg',
});
apiMocks.confirmTutorPhotoUpload.mockResolvedValue({
id: 2,
storage_key: 'tutors/7/photo.jpg',
});

const { result } = renderHook(() => useTutorPhotos(7, true));

await result.current.pickAndUpload();
await act(async () => undefined);

expect(apiMocks.requestTutorPhotoUploadUrl).toHaveBeenCalledWith(7, {
contentType: 'image/jpeg',
filename: 'avatar-1.jpg',
});
expect(apiMocks.confirmTutorPhotoUpload).toHaveBeenCalledWith(
7,
expect.objectContaining({
storage_key: 'tutors/7/photo.jpg',
content_type: 'image/jpeg',
size_bytes: 512,
}),
);
expect(apiMocks.getTutorPhotos).toHaveBeenCalled();
});

it('optimistically removes tutor photos and rolls back on failure', async () => {
apiMocks.getTutorPhotos.mockResolvedValue([{ id: 1, storage_key: 'tutors/7/one.jpg' }]);
apiMocks.deleteTutorPhoto.mockRejectedValue(new Error('network'));
const { result } = renderHook(() => useTutorPhotos(7, true));

await act(async () => undefined);
act(() => {
void result.current.remove(1);
});
const buttons = alertMocks.showAlert.mock.calls.at(-1)?.[2] as
| Array<{ onPress?: () => Promise<void> }>
| undefined;

await buttons?.[1]?.onPress?.();
await act(async () => undefined);

expect(apiMocks.deleteTutorPhoto).toHaveBeenCalledWith(7, 1);
expect(result.current.items).toEqual([{ id: 1, storage_key: 'tutors/7/one.jpg' }]);
});
});
Loading
Loading