Fixed bug where unlogged users could access user list page #296
+16
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhit-steineig
requested changes
Feb 9, 2026
Contributor
rhit-steineig
left a comment
rhit-steineig
left a comment
There was a problem hiding this comment.
Following the Steps To Reproduce in #247 no longer results in the bug, which is good. However, if you log out while already on the user list page, you can still edit the toggle. I think we should check if the user is logged in whenever they interact with the toggle and/or boot them off of the user list page when they log out to prevent this.
Also double check that I resolved the merge conflict with my linting stuff correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously users that were not logged in could access the user list page, and toggle a slider determining if they could edit or not. Now this has been removed.
closes #247