Skip to content

refactor(storage): remove 0.5 credential compatibility - #567

Merged
AptS-1547 merged 4 commits into
masterfrom
issue-463-full-edge-tests
Aug 20, 2026
Merged

refactor(storage): remove 0.5 credential compatibility#567
AptS-1547 merged 4 commits into
masterfrom
issue-463-full-edge-tests

Conversation

@AptS-1547

Copy link
Copy Markdown
Member

Summary

Closes #463.

This PR finalizes the AsterDrive 0.5.1 storage-policy schema boundary:

  • adds the final storage-policy cleanup migration;
  • rejects pre-0.5.1 databases with unmigrated legacy credentials before any DDL;
  • drops empty legacy credential tables, policy compatibility columns, indexes, and the remote-node foreign key;
  • removes the 0.5.x startup importer, connector legacy import hooks, deprecated entities/repositories, OneDrive legacy OAuth conversion, and migration-only tests;
  • updates database-migrate to copy only current policy envelopes and connector-owned credentials, while rejecting unmigrated legacy source data;
  • documents the release in CHANGELOG.md under v0.5.1.

Validation

  • cargo check -p aster_drive_migration
  • cargo check -p aster_drive --lib
  • cargo check -p aster_drive --tests
  • cargo test -p aster_drive_migration --lib
  • cargo test -p aster_drive --test platform migrations::
  • focused 0.5.1 legacy cleanup tests for rejection-before-DDL, empty-store cleanup, idempotency, and SQLite FK preservation
  • cargo fmt --all -- --check
  • git diff --check

The complete platform matrix was started separately; external PostgreSQL/MySQL smoke coverage remains environment-dependent.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@AptS-1547, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 6 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: c4277d15-a9a4-4536-bba2-06fa5a1f974e

📥 Commits

Reviewing files that changed from the base of the PR and between a3dd0ee and c50924f.

📒 Files selected for processing (33)
  • CHANGELOG.md
  • crates/aster_drive_migration/src/lib.rs
  • crates/aster_drive_migration/src/m20260820_000001_remove_storage_policy_legacy.rs
  • crates/aster_drive_model/src/deprecated/mod.rs
  • crates/aster_drive_model/src/deprecated/storage_connector_application_config.rs
  • crates/aster_drive_model/src/deprecated/storage_policy_credential.rs
  • crates/aster_drive_model/src/lib.rs
  • src/cli/database_migration/apply/convert.rs
  • src/cli/database_migration/apply/mod.rs
  • src/cli/database_migration/mod.rs
  • src/cli/database_migration/schema.rs
  • src/db/repository/mod.rs
  • src/db/repository/storage_connector_application_config_repo.rs
  • src/db/repository/storage_policy_credential_repo.rs
  • src/runtime/startup/common.rs
  • src/services/preview/wopi/targets.rs
  • src/services/storage_policy/credential/migration.rs
  • src/services/storage_policy/credential/mod.rs
  • src/storage/connectors/azure_blob.rs
  • src/storage/connectors/common.rs
  • src/storage/connectors/contract.rs
  • src/storage/connectors/mod.rs
  • src/storage/connectors/models.rs
  • src/storage/connectors/onedrive.rs
  • src/storage/connectors/s3.rs
  • src/storage/connectors/sftp.rs
  • src/storage/connectors/tencent_cos.rs
  • src/storage/connectors/test_support.rs
  • tests/legacy_storage_credential_migration.rs
  • tests/operations/cli.rs
  • tests/platform/database_backends.rs
  • tests/platform/migrations.rs
  • tests/platform/schema_drift.rs

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@astercommunity-automation astercommunity-automation Bot added Documentation Improvements or additions to documentation Priority: Medium Medium priority issue Rust Pull requests that update Rust code Scope: Storage Storage policies, connectors, drivers, provider capabilities, and storage backends Scope: Runtime Runtime lifecycle, async execution, tasks, and process-level performance Risk: High Changes a high-risk data, security, protocol, or deployment boundary CI: Running A pull request has required CI workflows that have not reached a terminal state labels Aug 20, 2026
@astercommunity-automation

astercommunity-automation Bot commented Aug 20, 2026

Copy link
Copy Markdown

PR readiness for c50924f721a1

Fact Value
Blocking conditions 1
Waiting conditions 0
Current unresolved threads 0
Current-head approvals 0
Stale latest reviews 0
  • BLOCK: Current head requires a human approval

This report is deterministic and updated for the current pull request head.

@astercommunity-automation astercommunity-automation Bot removed the CI: Running A pull request has required CI workflows that have not reached a terminal state label Aug 20, 2026
@astercommunity-automation

astercommunity-automation Bot commented Aug 20, 2026

Copy link
Copy Markdown

CI diagnostics resolved for c50924f721a1

Workflow Result First failing job/step
Rust CI PASS -
E2E PASS -
Docs Check PASS -
Multi-Primary E2E PASS -

This comment is updated in place for the latest PR head.

@AptS-1547
AptS-1547 force-pushed the issue-463-full-edge-tests branch from d347d33 to e21f835 Compare August 20, 2026 14:12
@AptS-1547 AptS-1547 self-assigned this Aug 20, 2026
@astercommunity-automation astercommunity-automation Bot added CI: Running A pull request has required CI workflows that have not reached a terminal state and removed CI: Running A pull request has required CI workflows that have not reached a terminal state labels Aug 20, 2026
@AptS-1547
AptS-1547 force-pushed the issue-463-full-edge-tests branch from e21f835 to f6e8e16 Compare August 20, 2026 15:04
@astercommunity-automation astercommunity-automation Bot added the CI: Running A pull request has required CI workflows that have not reached a terminal state label Aug 20, 2026
@codecov

codecov Bot commented Aug 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.17021% with 39 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/cli/database_migration/schema.rs 58.57% 29 Missing ⚠️
...c/m20260820_000001_remove_storage_policy_legacy.rs 94.41% 10 Missing ⚠️

📢 Thoughts on this report? Let us know!

@astercommunity-automation astercommunity-automation Bot removed the CI: Running A pull request has required CI workflows that have not reached a terminal state label Aug 20, 2026
@AptS-1547
AptS-1547 force-pushed the issue-463-full-edge-tests branch from f6e8e16 to 94c2a46 Compare August 20, 2026 15:37
@astercommunity-automation astercommunity-automation Bot added the CI: Running A pull request has required CI workflows that have not reached a terminal state label Aug 20, 2026
@astercommunity-automation astercommunity-automation Bot added CI: Passed All required CI workflows passed for the current pull request head and removed CI: Running A pull request has required CI workflows that have not reached a terminal state labels Aug 20, 2026
@astercommunity-automation astercommunity-automation Bot added CI: Running A pull request has required CI workflows that have not reached a terminal state and removed CI: Passed All required CI workflows passed for the current pull request head CI: Running A pull request has required CI workflows that have not reached a terminal state labels Aug 20, 2026
@astercommunity-automation astercommunity-automation Bot added CI: Passed All required CI workflows passed for the current pull request head CI: Running A pull request has required CI workflows that have not reached a terminal state and removed CI: Running A pull request has required CI workflows that have not reached a terminal state CI: Passed All required CI workflows passed for the current pull request head labels Aug 20, 2026
@AptS-1547
AptS-1547 force-pushed the issue-463-full-edge-tests branch from 2681773 to c50924f Compare August 20, 2026 18:28
@astercommunity-automation astercommunity-automation Bot added CI: Running A pull request has required CI workflows that have not reached a terminal state CI: Passed All required CI workflows passed for the current pull request head and removed CI: Running A pull request has required CI workflows that have not reached a terminal state labels Aug 20, 2026
@AptS-1547
AptS-1547 merged commit 089c9c1 into master Aug 20, 2026
18 of 19 checks passed
@astercommunity-automation astercommunity-automation Bot added Merged Pull request has been merged and removed CI: Passed All required CI workflows passed for the current pull request head labels Aug 20, 2026
@AptS-1547
AptS-1547 deleted the issue-463-full-edge-tests branch August 20, 2026 19:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Documentation Improvements or additions to documentation Merged Pull request has been merged Priority: Medium Medium priority issue Risk: High Changes a high-risk data, security, protocol, or deployment boundary Rust Pull requests that update Rust code Scope: Runtime Runtime lifecycle, async execution, tasks, and process-level performance Scope: Storage Storage policies, connectors, drivers, provider capabilities, and storage backends

Projects

None yet

Development

Successfully merging this pull request may close these issues.

refactor(storage): remove 0.5.0 credential compatibility in 0.6.0

1 participant