-
-
Notifications
You must be signed in to change notification settings - Fork 308
fix(pack): docker-language-server to dockerls #1707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
1 similar comment
Review ChecklistDoes this PR follow the [Contribution Guidelines](development guidelines)? Following is a partial checklist: Proper conventional commit scoping:
|
{
"williamboman/mason-lspconfig.nvim",
opts = function(_, opts)
opts.ensure_installed = opts.ensure_installed or {}
-- filter out the kotlin_language_server if it is already installed
opts.ensure_installed = vim.tbl_filter(
function(server) return server ~= "kotlin_language_server" end,
opts.ensure_installed
)
opts.ensure_installed = vim.tbl_filter(function(server) return server ~= "sqls" end, opts.ensure_installed)
table.insert(opts.ensure_installed, "tsp_server")
end,
config = function(_, opts)
require("mason-lspconfig").setup(opts)
end,
},I really don't know why but my mason-lspconfig setup function is not running till I manually added the config function. This is likely why no one has seen this error for 7 months as this is when this was committed. As soon as I did it started running again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes the naming convention for the Docker language server in the mason-lspconfig.nvim configuration. The change corrects the package identifier from the hyphenated form to the underscore form, which is the proper LSP server alias expected by mason-lspconfig.nvim.
- Updated
docker-language-servertodocker_language_serverfor mason-lspconfig.nvim
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.