Skip to content

fix: live transfer speed, receiver cancel, and sender/receiver byte-c… - #44

Merged
Aswanidev-vs merged 3 commits into
mainfrom
develop
Aug 16, 2026
Merged

fix: live transfer speed, receiver cancel, and sender/receiver byte-c…#44
Aswanidev-vs merged 3 commits into
mainfrom
develop

Conversation

@Aswanidev-vs

Copy link
Copy Markdown
Owner

…ount alignment

  • Speed now tracks bytes per recent window (rateTracker) instead of a lifetime average that only declines, in all three progress paths: sender, single-stream receiver, and segmented assembly
  • Cancelling on the receiving device aborts inbound streams within one chunk (cancellationReader), deletes the partial file, marks every file in the batch cancelled, and answers 499; segmented transfers share one cancel flag across parallel segments
  • The sender probes the peer's /api/status after an upload error and finalizes as cancelled (not a generic failure) when the peer cancelled, so both UIs agree; queued files stop too
  • TCP kernel buffers capped at 1 MiB (was 8 MiB) so the sender's buffered-bytes lead over the receiver shrinks from ~30 MB to a few MB; QUIC keeps its large UDP buffers via a separate control
  • 4 new regression tests: rolling rate vs lifetime average, cancellation reader, mid-stream inbound cancel, sender peer-cancel classification

…ount alignment

- Speed now tracks bytes per recent window (rateTracker) instead of a lifetime average that only declines, in all three progress paths: sender, single-stream receiver, and segmented assembly
- Cancelling on the receiving device aborts inbound streams within one chunk (cancellationReader), deletes the partial file, marks every file in the batch cancelled, and answers 499; segmented transfers share one cancel flag across parallel segments
- The sender probes the peer's /api/status after an upload error and finalizes as cancelled (not a generic failure) when the peer cancelled, so both UIs agree; queued files stop too
- TCP kernel buffers capped at 1 MiB (was 8 MiB) so the sender's buffered-bytes lead over the receiver shrinks from ~30 MB to a few MB; QUIC keeps its large UDP buffers via a separate control
- 4 new regression tests: rolling rate vs lifetime average, cancellation reader, mid-stream inbound cancel, sender peer-cancel classification
@qodo-code-review

Copy link
Copy Markdown

Qodo reviews are paused for this user.

Troubleshooting steps vary by plan Learn more →

On a Teams plan?
Reviews resume once this user has a paid seat and their Git account is linked in Qodo.
Link Git account →

Using GitHub Enterprise Server, GitLab Self-Managed, or Bitbucket Data Center?
These require an Enterprise plan - Contact us
Contact us →

@coderabbitai

coderabbitai Bot commented Aug 16, 2026

Copy link
Copy Markdown

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d2697ffd-ebf0-42bf-8930-54d21027f78e


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@codacy-production

codacy-production Bot commented Aug 16, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 35 complexity · 18 duplication

Metric Results
Complexity 35
Duplication 18

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

Comment thread internal/light/filetransfer.go Outdated
Comment thread internal/light/filetransfer.go Outdated
Aswanidev-vs and others added 2 commits August 16, 2026 11:23
…ed in path expression'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
…ed in path expression'

Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
@Aswanidev-vs
Aswanidev-vs merged commit f4178c3 into main Aug 16, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants