fix: re-add manual font fetching in <Head> - #782
Merged
Merged
Conversation
Turns out this is required because of some differences between dev and production build. Seems like the relevant font @import is not respected when combined with other stylesheets. Might be possible to avoid this manual declaration, but leaving that for another time. more or less a revert of daf4e96
mathiazom
requested review from
gorandalum,
reidzeibel and
strandlie
as code owners
September 2, 2026 14:13
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
rosvik
approved these changes
Sep 3, 2026
| return ( | ||
| <Html lang={language} data-theme={theme}> | ||
| <Head> | ||
| <link rel="preconnect" href="https://fonts.googleapis.com/" /> |
Member
There was a problem hiding this comment.
My understanding is that this doesn't do anything when there's a <link> with fonts.googleapis.com right below.
Suggested change
| <link rel="preconnect" href="https://fonts.googleapis.com/" /> |
Contributor
Author
There was a problem hiding this comment.
Usikker, det er slik Google Fonts bruker det 🤔 Så tenker det er ryddigst.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Turns out this is required because of some differences between dev and production build. Seems like the relevant font
@importis not respected when combined with other stylesheets (which is only the case for production build). Might be possible to avoid this manual declaration, but leaving that for another time.see MDN:
more or less a revert of daf4e96
Pre-fix (dev left, docker build right)