Repository navigation
serve-amd.sh: THINKING=off|on switch (issue #146) - #185
Merged
Merged
Conversation
THINKING=off appends --disable-thinking (the engine kill switch that
outranks every request); THINKING=on passes --default-chat-template-kwargs
'{"enable_thinking":true}' as the server default while clients can still
disable per request. Unset leaves today's behavior.
Generated with [Devin](https://devin.ai)
Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
THINKING=off|ontoserve-amd.sh, the Linux-side half of the [job] AMD launchers: one thinking switch and a serve-flag cleanup #146 thinking-switch done bar (the Windows-Thinkingswitch landed via Strix Halo Windows: Flash-Next port on main + MoE prefill transpose (2k TTFT ~2x) (supersedes #54) #80).offappends--disable-thinking— the engine kill switch that outranksenable_thinking,reasoning_effort, and Anthropicthinking:{enabled}.onpasses--default-chat-template-kwargs '{"enable_thinking":true}'as the server default; per-request overrides still win. Unset = unchanged behaviour.Evidence (strix, gfx1151)
--disable-thinkingno request surface returns reasoning (enable_thinking:true,reasoning_effort:"high", Anthropic thinking-enabled); positive control on the same server without the switch returned 399/593 reasoning chars (jobs 123/125).THINKING=off: no reasoning for any request.THINKING=on: silent request reasons; per-requestenable_thinking:falsestill wins. Unset: unchanged.Refs #146 (does not close — default-by-measurement + flag folding still open).
Test plan
Generated with Devin