Repository navigation
kernels: use __float2bfloat16 in batched_embed_nvfp4 so strix-hip builds (second break from #195) - #204
Open
AzeezIsh wants to merge 1 commit into
Open
kernels: use __float2bfloat16 in batched_embed_nvfp4 so strix-hip builds (second break from #195)#204AzeezIsh wants to merge 1 commit into
AzeezIsh wants to merge 1 commit into
Conversation
embed_from_argmax.cu is shared into kernels/strix-hip/common by symlink. HIP's bf16 header has no __float2bfloat16_rn, so the HIP build failed with "use of undeclared identifier". __float2bfloat16 is round-to-nearest-even on both CUDA and ROCm (static_cast<__bf16>), so GB10 output is unchanged; line 123 of the same file already uses it. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
Author
|
AMD train candidate gate: main 504063a + #197 + #204 (merged as b9ab4ed54), on strix (gfx1151, 64 GB):
So #204 together with #197 gives AMD a working main with no accuracy regression. A Flash-Next NVFP4 regression check of #195 on framework is still running. 🤖 Generated with Claude Code |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
batched_embed_nvfp4(added by #195 inkernels/gb10/common/embed_from_argmax.cu) calls__float2bfloat16_rn. HIP has no_rnvariant, and this.cuis symlinked into the strix-hip targets, so main stops building for gfx1151.__float2bfloat16rounds to nearest even on both CUDA and HIP, so the output does not change.This is the second strix-hip break on main. The first is #174's
atlas_pdl.cuhand friends, which #197 fixes. AMD needs both.The other
_rncall sites are only in GB10-only targets. I checked that none of them are symlinked into strix-hip.Verified
run-1792664799374893012).agentic-webserver, 50 iterations: 50/50 webserver_ok, 50/50 followed_directions, 12.43 s/turn (run-1792654228906033074).embed_from_argmaxcode objects are emitted for t0/t3/t4. Without this commit the build fails on__float2bfloat16_rn.agentic-webserver50/50, 50/50, 18.7 s/turn.🤖 Generated with Claude Code