Repository navigation
speculative: MTP ladder passes the ceiling through for a lone sequence only; n=2..4 back to 3 drafts - #273
Merged
Conversation
…e only; n=2..4 back to 3 drafts
Contributor
Author
|
Follow-up check: is anything left past C4? Main plus this PR's ladder (
With this PR, main matches 0.4.0 at C4 and C8, in both modes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
speculative/ladder.rs) started with(4, usize::MAX). qwen4_exp: serve NVIDIA's Qwen3.8-Flash-Next FP4-Local on its native formats (one GB10) #195 added that rung so qwen4_exp's MTP depth 4..7 reaches the verify at n≤4.[(1, usize::MAX), (4, 3), (8, 3), (16, 1), (32, 1)].ATLAS_MTP_K_LADDERstill overrides it.ATLAS_MTP_DYNAMIC_DEPTH=1,ATLAS_MTP_DEEP_MAX_SEQS=2, as in both profiles below), n≤2 doesn't use the ladder's value, so C1/C2 are unaffected.How it was found (#220)
ATLAS_MTP_MAX_SEQS=1and stays with the RDMA path off.ATLAS_MTP_ACCEPT_DEBUG, 0.4.0 drafts 3–4 positions at C4 where main drafts 7.ATLAS_MTP_K_LADDER='4:3,8:3,16:1,32:1'on main closes it: C4 141–144 vs 0.4.0's 140–144, C1 floor unchanged.Test plan
cargo test -p spark-model --lib ladder: 7 passed. Asserts updated: (1,5)=5, (2,5)=3, (4,5)=3, (8,5)=3, (16,5)=1, (1,7)=7.clippy and fmt clean.
Pair check of this branch's code on reiner + spark2 with the rc16 profile. Built fresh from
346ffb6fc; receipts in reiner's~/code/night1027/out/ladpr-346ffb6fc/.On SparkQwen 0.4.0's spark config, via this ladder as
ATLAS_MTP_K_LADDER: C4 142.3 vs 125.6, C1/C2/decode-floor unchanged (sqab9).Not measured: single-GB10 FP4-Local (qwen4_exp: serve NVIDIA's Qwen3.8-Flash-Next FP4-Local on its native formats (one GB10) #195's target) at n=2..4 without the deep path. There, n=2..4 returns to the pre-qwen4_exp: serve NVIDIA's Qwen3.8-Flash-Next FP4-Local on its native formats (one GB10) #195 value of 3.
Generated with Devin