Parameterize auth secret name, branding env, and genesis ports - #1
Open
markmattina wants to merge 1 commit into
Open
Parameterize auth secret name, branding env, and genesis ports#1markmattina wants to merge 1 commit into
markmattina wants to merge 1 commit into
Conversation
Replace the remaining upstream-hardcoded genesis values with values.yaml
knobs, each defaulting to the current upstream value so a default render is
byte-identical:
* auth.secretName (juno-auth-secret) -- consumed by the genesis AUTH_SECRET
env; still written by the create-nextauth-token PreSync Job/image.
* galaxy / icon -- the GALAXY and ICON branding env.
* ports.ui / ports.backend (3000 / 8000) -- threaded through the deployment
containerPorts, the Service, the ingress (auth-url + backends), and the
in-pod nginx proxy ConfigMap upstreams so one value updates all references.
Defaults preserved; verified `helm template` with default values diffs clean
against dev, and the values-dev (genesis-dev WARP/TLS) render is intact.
Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Parameterizes the remaining upstream-hardcoded values in the
genesiscomponent so they can be configured viavalues.yaml, while keeping every default identical to the current upstream value (a defaulthelm templaterender is byte-identical todev).This is a follow-up to the namespace de-hardcoding already on
dev.New values (all default to the current upstream value)
auth.secretName(juno-auth-secret) - consumed by the genesisAUTH_SECRETenv. Note: the secret is still written by thegenesis-create-nextauth-tokenPreSync Job (the image's/create-nextauth-secret), which uses this fixed name, so changing it requires image support.galaxy/icon- theGALAXYandICONbranding env (genuinely overridable).ports.ui/ports.backend(3000/8000) - threaded through the deploymentcontainerPorts, the Service, the ingress (auth-urlannotation + both backends), and the in-pod nginx proxy ConfigMap upstreams, so one value updates all references. These must match what the genesis image binds internally.Out of scope (left as-is)
:13000internal probe port and the titan/terra/metrics-gatherer ports.ClusterRole/ClusterRoleBindingfixed names (multi-install-per-cluster).Test plan
helm template genesis .(default values) diffs clean againstdev- no change.helm template genesis . -f values-dev.yamlrenders the genesis-dev Service (443/3000/8000), WARP annotation, auth secret, branding env, and proxy upstreams intact.helm lint .andhelm lint . -f values-dev.yamlpass.