Skip to content

fix: default libwally-core dependency to atomic #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
matthewjablack merged 5 commits into from
May 27, 2025
Merged

fix: default libwally-core dependency to atomic #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f4d75ed
fix: default libwally-core dependency to atomic
matthewjablack May 27, 2025
5ac42d6
ci: modernize workflows
matthewjablack May 27, 2025
3b3248b
ci: disable specific gcc warnings for googletest
matthewjablack May 27, 2025
e1f67b3
ci: limit concurrency to prevent job cancellation
matthewjablack May 27, 2025
1ed8240
ci: remove ubuntu 20.04
matthewjablack May 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
40 changes: 22 additions & 18 deletions .github/workflows/check_pre-merge_develop.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,28 @@ on:
branches:
- develop

# Limit concurrency to prevent job cancellations
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

env:
CMAKE_VERSION: 3.17.2
CMAKE_VERSION: 3.25.0

jobs:
cmake-win-test:
name: cmake build-win
runs-on: windows-2019
runs-on: windows-2022
strategy:
matrix:
generator: ['Visual Studio 16 2019', 'MSYS Makefiles']
generator: ['Visual Studio 17 2022', 'MSYS Makefiles']
shared: [on, off]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: cmake_version
run: cmake --version
- name: cmake_generage
- name: cmake_generate
run: cmake -S . -B build -G "${{ matrix.generator }}" -DENABLE_SHARED=${{ matrix.shared }}
- name: cmake_build
run: cmake --build build --config Release --parallel 4
Expand All @@ -35,17 +40,16 @@ jobs:

cmake-mac-test:
name: cmake build-mac
runs-on: ${{ matrix.os }}
runs-on: self-hosted
strategy:
matrix:
os: [macos-10.15]
# os: [macos-10.15, macos-11.0]
runner: [macos]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: cmake_version
run: cmake --version
- name: cmake_generage-macos
- name: cmake_generate-macos
run: cmake -S . -B build -G "Unix Makefiles" -DENABLE_SHARED=on -DENABLE_ELEMENTS=on
- name: cmake_build
run: cmake --build build --config Release --parallel 4
Expand All @@ -59,17 +63,17 @@ jobs:
cmake-ubuntu-test:
name: cmake build
runs-on: ${{ matrix.os }}
timeout-minutes: 30
strategy:
# Reduce concurrent jobs to prevent cancellations
max-parallel: 3
matrix:
os: [ubuntu-20.04, ubuntu-18.04]
os: [ubuntu-22.04]
shared: [on, off]
elements: [on, off]
exclude:
- os: ubuntu-18.04
elements: off

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: dump version
run: |
cmake --version
Expand All @@ -88,12 +92,12 @@ jobs:

doxygen-ubuntu:
name: doxygen-check
runs-on: ubuntu-18.04
runs-on: ubuntu-22.04

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: install_doxygen
run: sudo apt install doxygen graphviz
run: sudo apt-get update && sudo apt-get install -y doxygen graphviz
- name: doxygen_check
run: |
cd doc
Expand Down
40 changes: 22 additions & 18 deletions .github/workflows/check_pre-merge_master.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,23 +10,28 @@ on:
- master
- stable_v*

# Limit concurrency to prevent job cancellations
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

env:
CMAKE_VERSION: 3.17.2
CMAKE_VERSION: 3.25.0

jobs:
cmake-win-test:
name: cmake build-win
runs-on: windows-2019
runs-on: windows-2022
strategy:
matrix:
generator: ['Visual Studio 16 2019', 'MSYS Makefiles']
generator: ['Visual Studio 17 2022', 'MSYS Makefiles']
shared: [on, off]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: cmake_version
run: cmake --version
- name: cmake_generage
- name: cmake_generate
run: cmake -S . -B build -G "${{ matrix.generator }}" -DENABLE_SHARED=${{ matrix.shared }}
- name: cmake_build
run: cmake --build build --config Release --parallel 4
Expand All @@ -37,17 +42,16 @@ jobs:

cmake-mac-test:
name: cmake build-mac
runs-on: ${{ matrix.os }}
runs-on: self-hosted
strategy:
matrix:
os: [macos-10.15]
# os: [macos-10.15, macos-11.0]
runner: [macos]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: cmake_version
run: cmake --version
- name: cmake_generage-macos
- name: cmake_generate-macos
run: cmake -S . -B build -G "Unix Makefiles" -DENABLE_SHARED=on -DENABLE_ELEMENTS=on
- name: cmake_build
run: cmake --build build --config Release --parallel 4
Expand All @@ -61,17 +65,17 @@ jobs:
cmake-ubuntu-test:
name: cmake build
runs-on: ${{ matrix.os }}
timeout-minutes: 30
strategy:
# Reduce concurrent jobs to prevent cancellations
max-parallel: 3
matrix:
os: [ubuntu-20.04, ubuntu-18.04]
os: [ubuntu-22.04]
shared: [on, off]
elements: [on, off]
exclude:
- os: ubuntu-18.04
elements: off

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: dump version
run: |
cmake --version
Expand All @@ -90,12 +94,12 @@ jobs:

doxygen-ubuntu:
name: doxygen-check
runs-on: ubuntu-18.04
runs-on: ubuntu-22.04

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: install_doxygen
run: sudo apt install doxygen graphviz
run: sudo apt-get update && sudo apt-get install -y doxygen graphviz
- name: doxygen_check
run: |
cd doc
Expand Down
51 changes: 29 additions & 22 deletions .github/workflows/check_pre-merge_sprint.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,23 +8,28 @@ on:
branches:
- features/sprint*

# Limit concurrency to prevent job cancellations
concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

env:
CMAKE_VERSION: 3.15.5
CMAKE_VERSION: 3.25.0

jobs:
cmake-win:
name: cmake build-win
runs-on: windows-2019
runs-on: windows-2022
strategy:
matrix:
generator: ['Visual Studio 16 2019', 'MSYS Makefiles']
generator: ['Visual Studio 17 2022', 'MSYS Makefiles']
shared: [on]

steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4
- name: cmake_version
run: cmake --version
- name: cmake_generage
- name: cmake_generate
run: cmake -S . -B build -G "${{ matrix.generator }}" -DENABLE_SHARED=${{ matrix.shared }} -DENABLE_TESTS=on
- name: cmake_build
run: cmake --build build --config Release --parallel 4
Expand All @@ -35,17 +40,16 @@ jobs:

cmake-mac:
name: cmake build-mac
runs-on: ${{ matrix.os }}
runs-on: self-hosted
strategy:
matrix:
os: [macos-10.15]
# os: [macos-10.15, macos-11.0]
runner: [macos]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: cmake_version
run: cmake --version
- name: cmake_generage-macos
- name: cmake_generate-macos
run: cmake -S . -B build -G "Unix Makefiles" -DENABLE_SHARED=on
- name: cmake_build
run: cmake --build build --config Release --parallel 4
Expand All @@ -57,14 +61,17 @@ jobs:
cmake-ubuntu-coverage:
name: cmake build-ubuntu
runs-on: ${{ matrix.os }}
timeout-minutes: 45
strategy:
# Reduce concurrent jobs to prevent cancellations
max-parallel: 2
matrix:
os: [ubuntu-20.04, ubuntu-18.04]
os: [ubuntu-22.04]
shared: [on]
elements: [on, off]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: dump version
run: |
cmake --version
Expand All @@ -73,7 +80,7 @@ jobs:
if: matrix.elements == 'on'
run: |
cat /etc/os-release
sudo apt install lcov
sudo apt-get update && sudo apt-get install -y lcov
- name: cmake-build
run: |
cmake --version
Expand All @@ -95,20 +102,20 @@ jobs:
cd ..
- name: upload coverage
if: matrix.elements == 'on'
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: output-lcov-cfdcore-${{ matrix.os }}
path: ./build/lcov_cfdcore_output.zip

cmake-cpp-support-test:
name: cmake build-ubuntu C++ support test
runs-on: ubuntu-20.04
runs-on: ubuntu-22.04
strategy:
matrix:
cppversion: [11, 14, 17, 20]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: dump version
run: |
cmake --version
Expand All @@ -129,11 +136,11 @@ jobs:
runs-on: ${{ matrix.os }}
strategy:
matrix:
os: [ubuntu-18.04]
os: [ubuntu-22.04]
shared: [on]

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: dump version
run: |
cmake --version
Expand All @@ -153,19 +160,19 @@ jobs:
# --valgrind-stacksize=1048576 --num-callers=12
valgrind -v --tool=memcheck --leak-check=full --valgrind-stacksize=10485760 --log-file=./valgrind.log --time-stamp=yes ./build/Debug/cfdcore_test
- name: upload coverage
uses: actions/upload-artifact@v1
uses: actions/upload-artifact@v4
with:
name: valgrind-log
path: ./valgrind.log

doxygen-ubuntu:
name: doxygen-check
runs-on: ubuntu-18.04
runs-on: ubuntu-22.04

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
- name: install_doxygen
run: sudo apt install doxygen graphviz
run: sudo apt-get update && sudo apt-get install -y doxygen graphviz
- name: doxygen_check
run: |
cd doc
Expand Down
Loading