WIP: Update to match new specifications from dlc-specs PR 163#187
Closed
maxpolizzo wants to merge 39 commits into
Closed
WIP: Update to match new specifications from dlc-specs PR 163#187maxpolizzo wants to merge 39 commits into
maxpolizzo wants to merge 39 commits into
Conversation
d9a0bf2 to
4b7cb03
Compare
ea7aa80 to
2ef6aaf
Compare
f7e383d to
114a178
Compare
970db55 to
993da33
Compare
eb9fb65 to
30d1d54
Compare
30d1d54 to
7f3a5b9
Compare
2d4cbe6 to
3c29f36
Compare
…ckages/messaging/lib/messages/pre-167 --wip-- [skip ci]
…AttestationV0Pre167, DlcClose, DlcTransactions, OracleIdentifierV0, OrderAccept, OrderIrcInfo, OrderMetadata. Added OracleAttestationV0Pre163 and OracleIdentifierV0Pre163 classes with returned type in toJSON function. Renamed OracleIdentifierV0.ts to OracleIdentifier.ts. --wip-- [skip ci]
…erIrcInfo.ts and OrderMetadata.ts --wip-- [skip ci]
…cClose, OrderAccept, NodeAnnnouncementMessage, OracleAttestationV0Pre167 and OracleAnnouncementV0Pre167 --wip-- [skip ci]
…ry type conversions that had been used to circuvent the issue --wip-- [skip ci]
…aging/__tests__/messages/pre-163 --wip-- [skip ci]
…ec.ts --wip-- [skip ci]
…and temporaryConntractId keys everywhere --wip-- [skip ci]
…Pre163 and toPre163 functions --wip-- [skip ci]
…rs --wip-- [skip ci]
3c29f36 to
55e7831
Compare
…g deserialization --wip-- [skip ci]
de85a2a to
567d0e0
Compare
Contributor
|
Fixed in #223 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To do:
pre163andpre167folders withPre163orPre167suffix (7aa86d7c3d2ba68a8d86d8ec69498707dd8bb676)typeis returned bypre163classestoJSONfunction and make sure it is not in other classes. Classes where returnedtypehas been removed fromtoJSONfunction must have apre163version for backwards compatibility. (6916ce7b2c031af238a7a46197a59a3574b0ea3d)DlcMessage.tsto handle BigSize type deserialisation (bffd2c3be4d6e788a3e9741cbcf14f4869700f01)DlcOffer,DlcAccept, andDlcSign,DlcCancel,DlcClose,DlcIds,DlcInfo,DlcTransactions,NodeAnnouncementMessage,OrderAccept,OrderIrcInfo,OrderMetadata,OrderOffermessages should useUint16to deserializetype, and all sub-messages should useBigSizeiftypeis used for deserialisation (post163,typeis only used for deserialisation when there are several possible sub-types for a message class)typeshould be inferred from the class itself (i.e. the class does not carrytype), otherwisetypeshould be added to the classlengthinOracleIdentifier.ts,OrderIrcInfo.tsandOrderMetadata.ts(20c4bcab5787b2d7947fd9c7d0cc63f088f1c8b2)ca939d55a1c1da8f5fd320d8fd523bc8c78d24b4)readerinstantiation inpre163, use new instantiation elsewhere (a7cca04b2b6dc49a59683fa41b75ce2513be145f)DlcOffer,DlcAcceptandDlcSignandOrderOfferalready have TLV streams enabled. Add TLV streams toDlcClose,OrderAccept,NodeAnnnouncementMessage,OracleAttestationV0Pre167andOracleAnnouncementV0Pre167(a142ab5fe728d1faac6ef76e260004f0611929b7)OrderAccept(458ea8390ce9c6f809d2a72592908743b340d676)messages/ContractInfo.ts, re-implementDisjointContractInfo.validate(335895bc1e7d8b53ced2e90e7c24822e13ab123a)ContractDescriptor.tsanassertclause was added to thedeserializefunction to check that the deserialised type is as expected: generalise this everywhere (34290675df4e81c685e5686c4dce68cf5e72a86b)rocksdbpackage (59f4fcb762c50d6eaadeef2efbb47094be71cefe)corepackage (e63be5d80dd77098f3b98167827ba3ff96fe9517)bignumber.jsand@node-dlc/bitcoinand remove unnecessary type conversions that had been used to circumvent the issue (1fbe6796cae9dd7f76503f116c6fc4c89d3ae1e1)messagingpackage (7cb1b78584f1ea15c37b049804b893ed5d87eb7c)messagingpackage (2edfc54de3d548b15d4de188aa973b93dcce86b2)NodeAnnouncementMessage.spec.tstest (4d32771fa631e2bcb9ff42b56a4268115eca7608)rocksdbpackages and generalise usingofferCollateral,acceptCollateralandtemporaryConntractIdorders keys everywhere (19f48306a1df3dfbd4382172b685494d8ce9249a)transportpackage (86c783e52285282b6a31b9c0b0be44201ca52364)toPre163function to post-163 classes in messaging package and add corresponding tests (0fb761fd8a7b0d41f9c80183659c402e95cdbee4)ScriptWitnessserialisation (fd856e6196b9dc36c7e7f832e1da49e45f08de53)677d168ecd013c952a8a40f5e7267e79343d100e)3b88c99c6e6f4832fa58fa7f5df496f162f7879c)masterbranch55e78311d2a71e9da8651f098743adb0dad88a91)masterbranch again after new commit tomasterbranchdeserializedBytesduring deserialization (567d0e0e65bc859f9e8cd41d88184ad3ac7bc7cd)