chore: upgrade ESLint tooling and improve code quality across packages#226
Merged
matthewjablack merged 1 commit intoJul 14, 2025
Merged
Conversation
matthewjablack
force-pushed
the
chore/eslint-upgrade-and-code-quality-improvements
branch
from
0729a9d to
670e495
Compare
- upgrade ESLint from v7 to v8 and related plugins - upgrade TypeScript ESLint from v4 to v5 - add simple-import-sort/exports rule for consistent export ordering - reorganize imports/exports alphabetically across all packages - fix TypeScript types: BigInt → bigint, improve type safety - update tsconfig.json files with consistent build output configuration - improve BigNumber usage with string literals for precision - use 'as const' for better type inference on variant properties
matthewjablack
force-pushed
the
chore/eslint-upgrade-and-code-quality-improvements
branch
from
670e495 to
4d0893d
Compare
matthewjablack
deleted the
chore/eslint-upgrade-and-code-quality-improvements
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR upgrades our ESLint tooling and implements consistent code quality improvements across all packages in the monorepo.
Changes Made
Tooling Updates
Upgraded ESLint from v7 to v8 along with the corresponding TypeScript ESLint plugin from v4 to v5. Also updated eslint-config-prettier, eslint-plugin-prettier, and simple-import-sort to their latest versions. Added the
simple-import-sort/exportsrule to ensure consistent export ordering throughout the codebase.Code Quality Improvements
Reorganized imports and exports alphabetically across all packages to improve code consistency and readability. Fixed TypeScript types by replacing
BigIntwith the properbigintprimitive type. Enhanced type safety by usingas constassertions on variant properties in the messaging package. Updated BigNumber usage to use string literals for better precision handling. Simplified the logic in thevarIntBytes.tsfunction and updated tsconfig.json files with consistentoutDirandincludeconfigurations.Packages Affected
This touches the bitcoin, bufio, chainmon, checksum, core, leveldb, logger, messaging, noise, and wire packages.
Testing
All existing tests should continue to pass as these changes are purely organizational and don't affect public APIs. The import/export reorganization maintains all existing functionality while improving code structure.
Breaking Changes
None. This is purely internal code organization and tooling improvements that don't affect the public API surface.