refactor(tests): Improve test readability by converting batch summaries to individual test cases#227
Merged
matthewjablack merged 1 commit intoJul 19, 2025
Conversation
- replace aggregate pass/fail summaries with granular test cases - generate individual tests per test vector for better debugging - remove emoji output and use proper expect() assertions - reduce code complexity: 408→137 lines (-271 lines) - enable targeted testing with --grep on specific test vectors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The compatibility tests were using batch summaries that made debugging difficult:
Solution
Convert all batch test summaries to individual test cases:
Before:
DlcOffer Serialization Test Results:
Passed: 14/14
Failed: 0/14
✓ should test DlcOffer serialization against all test vectors
After:
✓ should correctly serialize DlcOffer for enum_3_of_3_test.json
✓ should correctly serialize DlcOffer for enum_3_of_5_test.json
✓ should correctly serialize DlcOffer for enum_and_numerical_3_of_5_test.json
Benefits
npm test -- --grep "enum_3_of_3_test.json"expect()assertionsTest Coverage
Now provides 127 individual test cases instead of aggregate summaries:
🔍 Testing
Each test failure now provides clear context about which test vector and operation failed, dramatically improving debugging experience.