Repository navigation
Conversation
Pending Engram work from the Hermes dev tree, now reviewed through Argus. - _call_llm takes base_url; OpenAI-compatible /chat/completions path, reasoning_content fallback - run_ingest gains provider/base_url - dialectical + cli tweaks; pyproject updated Tests: 29 passed (pytest tests/).
{
"schema_version": 1,
"head_sha": "9899f57c2237eee09d93018df10bbb0b75acbd17",
"status": "clear",
"review_complete": true,
"merge_confidence": 4,
"confidence_reason": "The configured non-Anthropic endpoint is now passed through the normal CLI path without credential-pool substitution; only configuration documentation remains as optional follow-up.",
"blocking_findings": [],
"advisory_findings": [
{
"id": "NUBIS-004",
"severity": "P3",
"file": "config.example.json",
"line": 6,
"problem": "The new ingestion behavior requires `llm_base_url` (and optionally `llm_api_key_env`) for an OpenAI-compatible provider, but the checked-in config template and README still only describe the Anthropic configuration. A user copying the template has no documented way to configure the feature added by this PR.",
"required_fix": "Optionally document the OpenAI-compatible configuration keys and an example endpoint/API-key environment variable in the config template or README.",
"acceptance_criteria": "Documentation shows a valid non-Anthropic `llm_provider`, `llm_base_url`, model, and API-key environment-variable configuration that corresponds to the CLI ingestion path."
}
],
"blockers": [],
"checks_run": [
{
"command": "argus-native-gates ci Atomlaunch/engram 9899f57c2237eee09d93018df10bbb0b75acbd17",
"result": "Helper could not complete because it raised JSONDecodeError parsing GitHub API output; direct repository-scoped REST evidence was used instead."
},
{
"command": "argus-native-gates risk --repo /home/triage/triage-agent/worktrees/engram-pr6 --base origin/main --head 9899f57c2237eee09d93018df10bbb0b75acbd17",
"result": "mac_build_required=false; no native, bundle, sandbox, helper, or Mac-build risk paths changed."
}
],
"ci": {
"state": "green",
"checked_at_sha": "9899f57c2237eee09d93018df10bbb0b75acbd17",
"checks": [
{
"name": "test (3.11)",
"status": "completed",
"conclusion": "success"
},
{
"name": "test (3.12)",
"status": "completed",
"conclusion": "success"
},
{
"name": "test (3.13)",
"status": "completed",
"conclusion": "success"
}
]
},
"mac_verification": {
"required": false,
"reasons": [],
"reported": false,
"report_url": null,
"report_sha": null
},
"resolved_finding_ids": [
"NUBIS-003"
],
"handoff": {
"target": null,
"reason": "Review is clear for the current head; NUBIS-004 is optional advice and the two prior automatic handoff rounds are already used.",
"round": 2,
"action": "not_needed"
}
}Nubis VerdictMerge confidence: 4/5 Summary
Findings
Resolved findings
Review basis
RecommendationCode review is clear at this head. The documentation note is optional and does not block merge readiness. Review mode: Code-only review; no local build/test/lint/typecheck was run. Merge confidence: 4/5 |
|
@cursor Address the required fixes from Nubis's review of 8850577: #6 (comment). Preserve finding IDs, push safe fixes to this PR branch, and let the new commit trigger Nubis re-review. Do not merge or deploy. Builds/tests remain opt-in under the existing review policy. Repository/PR: #6 Required findings:
|
- NUBIS-001: _extract_json_text keeps the complete JSON object from reasoning-only
completions (whole text, fenced block, or balanced {...} span); non-JSON still
returns None. Tests: tests/test_ingest_llm.py.
- NUBIS-002: anthropic and requests are core dependencies again; extras kept as aliases.
- NUBIS-GATE-CI: GitHub Actions runs pytest on 3.11-3.13 from a default install.
|
@cursor Address the required fixes from Nubis's review of 66506c0: #6 (comment). Preserve finding IDs, push safe fixes to this PR branch, and let the new commit trigger Nubis re-review. Do not merge or deploy. Builds/tests remain opt-in under the existing review policy. Repository/PR: #6 Required finding:
CI is green for this head. The prior NUBIS-001, NUBIS-002, and CI-gate findings are resolved. |
- run_ingest fills provider, llm_base_url and llm_api_key_env (default OPENAI_API_KEY) from the Engram config; explicit arguments still win. - A configured/caller endpoint is never replaced by a Hermes credential-pool endpoint; the Anthropic env/.env key lookup only applies to the anthropic provider. - engram ingest forwards provider and base_url from config. - tests/test_ingest_endpoint.py: CLI ingest hits exactly <llm_base_url>/chat/completions even with an unrelated credential pool present.
Opened by Jarvis so Argus reviews Engram changes before they ship (TheDev, 10/23).
What:
_call_llmcan use any OpenAI-compatible/chat/completionsendpoint viabase_url(falls back toreasoning_contentfor reasoning models); Anthropic stays the default.run_ingestgainsprovider/base_url. Small dialectical/cli/pyproject updates.Tested:
pytest tests/: 29 passed.Not merging until Argus and TheDev are happy.