Repository navigation
Foundation is the Swift SDK's on Android and the web: Isomer's Swift SDKs (0.56) - #232
Open
logan-shire-agent[bot] wants to merge 4 commits into
Open
logan-shire-agent[bot] wants to merge 4 commits into
logan-shire-agent[bot] wants to merge 4 commits into
Conversation
…SDKs registered by URL, foundation/'s sources moved to isomer_hermetic_toolchains (docs/hermetic_toolchains.md) Isomer's Swift SDKs (AttilaTheFun/isomer_hermetic_toolchains, isomer-6.4.2) are swift.org's 6.4.2 Android and WebAssembly SDKs with corelibs Foundation taken out and Isomer's Foundation, FoundationNetworking, IsomerFoundation, CoreGraphics and Combine put in, plain or -i18n (FoundationInternationalization and the SDK's ICU), so every `import Foundation` there is Isomer's with no dependency declared. - Package.swift: no Foundation, FoundationNetworking or IsomerFoundation targets and no swift-foundation dependency; CoreGraphics and Combine for Linux and Windows only. - @isomer//:foundation and :isomer_foundation empty on Android and the web; //core_graphics and //frameworks/combine the SDK's there. Foundation's configure_package target_deps gone (isomer's and the examples'). - --@isomer//foundation:internationalization checks that the -i18n SDK is registered. - isomer registers the -i18n SDKs (Foundation's tests and ICU's trimming run against them), the examples the plain ones; rules_swift 4.2.2.isomer.4 for swift.android_sdk(url = ...). - FileWrapper.swift to shared/swift_ui_corelibs; tools/foundation/check_link.py removed; tools/parity reads the SDK's Foundation family. - README: "Isomer's Swift SDKs", one snippet a platform, and the Upgrading notes.
…990, #1995 and #2000); the SDKs' checksums at isomer_hermetic_toolchains 42fd9591; the single-object lesson in docs/hermetic_toolchains.md
…droid and wasm without explicit modules, and the shared cache then holds two _Builtin_stddef)
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Foundation on Android and the web becomes the Swift SDK's: Isomer's Swift SDKs (AttilaTheFun/isomer_hermetic_toolchains, branch
isomer-6.4.2) are swift.org's 6.4.2 SDKs with corelibs Foundation taken out and Isomer's Foundation family put in, so everyimport Foundationthere (an app's, a package's, a module's) is Isomer's with no@isomer//:foundationedge. docs/hermetic_toolchains.md has the design; README's "Isomer's Swift SDKs" and "Upgrading isomer" have what a consumer writes.swiftblock:swift.android_sdk(url = …, sha256 = …)and/orswift.wasm_sdk(url = …, sha256 = …), the plain SDK, or the-i18none (FoundationInternationalization and ICU) for an app that formats dates or numbers. An app that builds for Android alone registers no wasm SDK.@isomer//:foundationand@isomer//:isomer_foundationare empty dependencies on Android and the web, so existing BUILD files keep working. Foundation'sconfigure_package(target_deps = …)entries are gone (isomer's and the examples').foundation/'s sources moved to the toolchains repository'sIsomer/Sources.foundation/keeps the build settings,one_configurationand Foundation's tests, which build against the SDK's Foundation. FileWrapper.swift moves toshared/swift_ui_corelibsfor Linux's and Windows' SwiftUI.--@isomer//foundation:internationalizationstays. On Android and the web it now checks that the -i18n SDK is registered: a build that sets it with the plain SDK fails and names the SDK to use.swift.android_sdk(url = …)(rules_swift#2012), with #1860, #1990, #1995 and #2000 as patches. 4.3.0 builds Android and wasm without explicit modules (#1999), and their implicitly built Clang modules then conflict in the shared module cache ("module '_Builtin_stddef' is defined in both"):.bazelrcand examples/.bazelrc turnswift.use_global_module_cacheoff until rules_swift does that for those toolchains.tools/foundation/check_link.pyis removed (there is one Foundation to link).tools/parityreads the SDK's Foundation family on wasm.Checked in leased containers, with the SDKs built at isomer_hermetic_toolchains 42fd9591 (CI's plain builds there match byte for byte), passed by
--distdir:--@isomer//foundation:internationalizationwith the plain SDK fails, naming the -i18n one.Draft until the SDKs' release (
isomer-6.4.2.1) is published and the registry has 4.3.0.isomer.1: CI downloads both, so it can't pass before then.