Conversation
Bumps react-router-dom from 6.30.0 to 7.15.0 to match body-editor, which drifted to v7 in an unrelated dependency-bump commit (LEAN-5586). Rather than downgrade body-editor back to v6, we're moving the rest of the ecosystem forward — react-router v7 kept v6's API surface, and this repo's only usages (useSearchParams, useLocation, useNavigate passed through as props) are unaffected. Companion PRs bump leanworkflow-dashboard and manuscripts-style-guide to the same version. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the application’s direct react-router-dom dependency to align with the ecosystem goal of standardizing on React Router v7, primarily by moving from 6.30.0 to 7.15.0 and updating the lockfile accordingly.
Changes:
- Bump
react-router-domfrom6.30.0to7.15.0inpackage.json. - Regenerate
pnpm-lock.yamlto remove the v6 router packages and reflect the v7 dependency graph.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updates the direct react-router-dom dependency to 7.15.0. |
| pnpm-lock.yaml | Updates the resolved router packages to v7 and removes v6-related entries. |
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| "react-is": "18.3.1", | ||
| "react-popper": "2.3.0", | ||
| "react-router-dom": "6.30.0", | ||
| "react-router-dom": "7.15.0", |
Contributor
|
Published version |
Contributor
|
Published version |
Contributor
|
Published version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
useSearchParams,useLocation,useNavigate(passed through as props into@manuscripts/body-editor) — are unaffected.Test plan
pnpm typecheckpassespnpm test— 13/13 passpnpm lintpassespnpm buildsucceeds🤖 Generated with Claude Code