LEAN-6048: Collapse projectID/manuscriptID into a single docID by mnatsheh · Pull Request #1242 · Atypon-OpenSource/manuscripts-article-editor

mnatsheh · 2026-09-18T19:10:32Z

Summary

manuscripts-cf-worker addresses a document by one opaque docID, not a (projectID, manuscriptID) pair. EditorAppProps and everything that threads through the store now take a single docID: Api.ts's doc-related calls, Store's state, BasicSource, ApiSource, buildData, buildUtilities, StepsExchanger, and use-create-editor all collapse to one docID field.
api.getProject/getUserProfiles/getProjectPermittedActions were never part of manuscripts-cf-worker's /v3 API to begin with (pre-existing gap) — they now just reuse the same docID value where projectID used to go.
use-create-editor.ts no longer passes projectID into @manuscripts/body-editor's useEditor() — that prop was dead there (see manuscripts-body-editor's matching PR removing it from EditorProps).
Since these endpoints don't exist against manuscripts-cf-worker: getUser() returns a static profile, buildData()'s userRole is a static ProjectRole.owner, manuscriptPermittedActions is a fixed list, and useGetUserName() returns a static 'User'.

Note

Depends on manuscripts-body-editor's projectID removal being published — until then, pnpm typecheck (and this repo's pre-push hook) fails on the missing projectID prop, since the currently-published body-editor still requires it. Verified locally against a linked build of that change; pushed here with --no-verify at the user's request since this is a known, expected, temporary cross-repo ordering issue.

Test plan

pnpm test — 13/13 pass
pnpm typecheck passes once linked against manuscripts-body-editor's matching change

🤖 Generated with Claude Code

manuscripts-cf-worker addresses a document by one opaque docID, not a (projectID, manuscriptID) pair, so EditorAppProps and everything that threads through the store now take a single docID: Api.ts's doc-related calls, Store's state, BasicSource, ApiSource, buildData, buildUtilities, StepsExchanger, and use-create-editor all collapse to one docID field. api.getProject/getUserProfiles/getProjectPermittedActions were never part of manuscripts-cf-worker's /v3 API to begin with (that gap predates this change) — they now just reuse the same docID value where projectID used to go, rather than inventing a second identifier for them. use-create-editor.ts no longer passes projectID into @manuscripts/body-editor's useEditor() — that prop was dead there (see manuscripts-body-editor's matching change removing it from EditorProps). Also, since these endpoints don't exist against manuscripts-cf-worker: - getUser() returns a static profile instead of calling GET /user - buildData()'s userRole is a static ProjectRole.owner instead of derived from a fetched project - buildData()'s manuscriptPermittedActions is a fixed list instead of fetched via getProjectPermittedActions (now unused and removed) - useGetUserName() returns a static 'User' instead of deriving a name from project/hostUsers/collaboratorsById Requires manuscripts-body-editor's projectID removal to typecheck clean (verified locally against a linked build). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Copilot

🟡 Changes recommended

Unresolved critical WebSocket, credential, and identity issues plus moderate data and permissions issues block approval.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

This PR collapses projectID and manuscriptID into a single docID across the editor and manuscripts-cf-worker integration.

Changes:

Threads docID through props, store state, sources, and collaboration.
Updates document, steps, and WebSocket API handling.
Adds static user, role, permission, and username fallbacks.

File summaries

File	Summary and final review findings
`src/store/Store.ts`	Replaces project/manuscript identifiers with `docID`.
`src/Main.tsx`	Threads `docID` into the editor.
`src/index.tsx`	Updates public props and memoization.
`src/hooks/use-get-user-name.ts`	Uses a static username.
`src/hooks/use-create-editor.ts`	Initializes the editor and collaboration with `docID`.
`src/EditorApp.tsx`	Initializes sources with `docID`.
`src/api/StepsExchanger.ts`	Uses document-scoped collaboration calls.
`src/api/buildUtilities.ts`	Updates utility arguments. Moderate (3 votes): `refreshProject()` calls an unavailable project endpoint and can reject; use a supported document operation.
`src/api/buildData.ts`	Adds static roles and permissions. Moderate (2 votes): the returned data omits required `project` state. Moderate (3 votes): the unsupported user-profiles request always fails. Moderate (1 vote): missing `handleSuggestion` disables suggestion acceptance.
`src/api/ApiSource.ts`	Builds API data using `docID`.
`src/api/Api.ts`	Updates document endpoints and WebSocket authentication. Critical (3 votes): pending joins can create sockets and reconnect after shutdown. Critical (1 vote): bearer tokens are exposed in WebSocket URLs. Critical (1 vote): the hard-coded identity can misattribute users and comments.

Review details

Suppressed comments (1)

src/api/buildData.ts:25

This fixed list never includes ManuscriptActions.handleSuggestion. getCapabilities maps that action directly to can.handleSuggestion, and SuggestionActions only renders Accept when it is enabled, so this migration removes approval of every suggestion. Include the action if the static owner permissions are meant to preserve the existing editor behavior.

const STATIC_MANUSCRIPT_PERMITTED_ACTIONS: ManuscriptActions[] = [
  ManuscriptActions.rejectOwnSuggestion,
  ManuscriptActions.handleOwnComments,
  ManuscriptActions.resolveOwnComment,

Files reviewed: 11/11 changed files
Comments generated: 6
Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

+  getUser = async (): Promise<UserProfile> => ({
+    _id: 'static-user-profile-id',
+    userID: 'static-user-id',
+    connectID: 'static-connect-id',
+  })


+    const join = async () => {
      try {
+        const token = await this.getAuthToken()
+        const url = `${base.href}${path}?token=${encodeURIComponent(token ?? '')}`


+    const join = async () => {
      try {
+        const token = await this.getAuthToken()
+        const url = `${base.href}${path}?token=${encodeURIComponent(token ?? '')}`
        ws = new WebSocket(url)


  const profilesById = new Map()
  profilesById.set(user._id, user)
-  const profiles = await api.getUserProfiles(projectID)
+  const profiles = await api.getUserProfiles(docID)


+    userRole: ProjectRole.owner,
    ...users,
    ...state,
    ...doc,
-    project,
-    manuscriptPermittedActions,
+    manuscriptPermittedActions: STATIC_MANUSCRIPT_PERMITTED_ACTIONS,


    const [project, document] = await Promise.all([
-      api.getProject(projectID),
-      api.getDocument(projectID, manuscriptID),
+      api.getProject(docID),


- state.project/refreshProject and Api.getProject/getProjectPermittedActions were dead (never read) — removed, along with the now-unused Project import. - WMsPermittedActions/manuscriptPermittedActions collapse into a single permittedActions: string[], stored as-is from host app props. The two former enums (body-editor's Actions, transform's ManuscriptActions) merge into one local Actions enum in lib/capabilities.tsx, since there's no longer a distinction to preserve. - The current user and collaborator list now come entirely from host app props instead of being fetched: EditorAppProps gains a required currentUser: User prop alongside the existing users?: User[] (state.users, renamed from hostUsers). HostUser and UserProfile-typed state (user/collaborators/collaboratorsById) collapse into one local User type (HostUser's fields minus the unused connectId). Api.getUser/getUserProfiles and buildData's user-fetching gate are removed accordingly. - getCurrentUser is dropped from the body-editor props object built in use-create-editor.ts — it was never read on the body-editor side either (see companion body-editor change removing it from EditorProps). - useGetUserName converts from a hook to a plain getUserName(users, userID) function in lib/get-user-name.ts: it was only ever a thin lookup over state.users, and both call sites already subscribe via useStore themselves, so a second hook subscription added nothing. - userRole/ProjectRole/getUserRole (lib/roles.ts) are removed entirely — the only value ever assigned was a hardcoded ProjectRole.owner, nothing read it, and the underlying role computation depended on the already-removed state.project. Requires manuscripts-body-editor's LEAN-6048 (Actions enum + getCurrentUser removal) to typecheck clean end-to-end — verified locally against a linked build; the registry-published body-editor is one version behind until that lands. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Every real consumer of state.user (comment/suggestion ownership checks, the userID attr written onto new comments, the userID passed to body-editor) only ever read .id — so the User object gave nothing over the userID field that was already declared (if unused) on state. EditorAppProps.currentUser/currentUserID collapses the same way into userID: string. state.users (the roster, used by getUserName) keeps the full User shape, now imported from @manuscripts/transform instead of being defined locally. Requires manuscripts-transform's LEAN-6048 (User export replacing UserProfile) to typecheck clean — verified locally against a linked build; the registry-published transform is one version behind until that lands. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>

Copilot AI lite review requested due to automatic review settings September 18, 2026 19:10

Copilot started reviewing on behalf of mnatsheh September 18, 2026 19:11 View session

Copilot AI reviewed Sep 18, 2026

View reviewed changes

mnatsheh mentioned this pull request Sep 18, 2026

LEAN-6048: Remove dead projectID prop from EditorProps Atypon-OpenSource/manuscripts-body-editor#1011

Open

2 tasks

mnatsheh and others added 2 commits September 21, 2026 14:03

Navigation Menu

LEAN-6048: Collapse projectID/manuscriptID into a single docID - #1242

LEAN-6048: Collapse projectID/manuscriptID into a single docID#1242
mnatsheh wants to merge 3 commits into
masterfrom
LEAN-6048

mnatsheh commented Sep 18, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

mnatsheh commented Sep 18, 2026

Summary

Note

Test plan

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Suppressed comments (1)

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants