Skip to content

LEAN-4642 SDT-030 - Add support for @article-type to Manuscripts temp… - #27

Open
fwaisi wants to merge 2 commits into
masterfrom
LEAN-4642
Open

fwaisi wants to merge 2 commits into
masterfrom
LEAN-4642

Conversation

@fwaisi

@fwaisi fwaisi commented Jun 22, 2025

Copy link
Copy Markdown
Contributor

…lates

@fwaisi
fwaisi requested review from Copilot and mbetamony June 22, 2025 10:23

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

The PR adds support for an optional articleType field to the manuscript template JSON schema.

  • Introduces a new articleType property as a string.
  • Updates the schema file to include this field alongside existing properties.
Comments suppressed due to low confidence (3)

schemas/concrete/MPManuscriptTemplate.json:274

  • Add a description attribute to the articleType property explaining its purpose and expected values.
        "articleType": {

schemas/concrete/MPManuscriptTemplate.json:275

  • Consider defining an enum of allowed article types (e.g., 'research', 'review') instead of a free-form string to enforce valid values.
          "type": "string"        

schemas/concrete/MPManuscriptTemplate.json:278

  • Add schema validation tests for the new articleType field, covering both valid and invalid values to ensure correct behavior.
      "required": ["title"]

Comment thread schemas/concrete/MPManuscriptTemplate.json Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants