LEAN-5581: Revive manuscripts-eslint-config and Standardize Linting A… - #118
Open
AlaAlkhalaileh wants to merge 14 commits into
Open
AlaAlkhalaileh wants to merge 14 commits into
AlaAlkhalaileh wants to merge 14 commits into
Conversation
…cross Apps Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the repository’s linting setup to rely more directly on @manuscripts/eslint-config, with the apparent goal of standardizing ESLint configuration across Manuscripts apps.
Changes:
- Removes a large set of ESLint-related devDependencies (plugins/parsers/config helpers) from
package.json. - Simplifies
eslint.config.mjsto directly export the shared Manuscripts ESLint config (removingFlatCompat,@eslint/js, and local plugin wiring).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Removes explicit ESLint plugin/parser devDependencies in favor of the shared config package. |
| eslint.config.mjs | Switches from FlatCompat-based adaptation to directly spreading the shared config into ESLint flat config. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
36
to
43
| "devDependencies": { | ||
| "@manuscripts/eslint-config": "0.5.1", | ||
| "@manuscripts/transform": "4.3.27", | ||
| "@eslint/eslintrc": "3.3.1", | ||
| "@eslint/js": "9.39.1", | ||
| "@types/debug": "4.1.12", | ||
| "@types/jest": "30.0.0", | ||
| "@types/node": "20.17.46", | ||
| "@typescript-eslint/eslint-plugin": "8.46.4", | ||
| "@typescript-eslint/parser": "8.46.4", | ||
| "eslint": "9.39.1", | ||
| "eslint-config-prettier": "10.1.8", | ||
| "eslint-plugin-diff": "2.0.3", | ||
| "eslint-plugin-header": "3.1.1", | ||
| "eslint-plugin-import": "2.32.0", | ||
| "eslint-plugin-jest": "29.1.0", | ||
| "eslint-plugin-jsx-a11y": "6.10.2", | ||
| "eslint-plugin-mdx": "3.6.2", | ||
| "eslint-plugin-node": "11.1.0", | ||
| "eslint-plugin-prettier": "5.5.4", | ||
| "eslint-plugin-promise": "7.2.1", | ||
| "eslint-plugin-react": "7.37.5", | ||
| "eslint-plugin-react-hooks": "7.0.1", | ||
| "eslint-plugin-simple-import-sort": "12.1.1", | ||
| "husky": "8.0.3", |
mbartenev-atypon
approved these changes
May 14, 2026
mbartenev-atypon
approved these changes
May 14, 2026
Contributor
|
Published version |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…cross Apps