Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds four new skipped test cases for testing open slice ends in ReplaceAroundStep operations, and updates the manuscript-simple.json fixture document to be compatible with the current manuscript-transform schema. Corresponding position adjustments were made in tests that reference the updated fixture.
Changes:
- Added 4 new skipped test cases for tracking various ReplaceAroundStep scenarios with open slice ends
- Updated
manuscript-simple.jsonfixture to include new required wrapper nodes (title,abstracts,body,backmatter,comments) and attributes - Adjusted position indices in existing tests that use the updated manuscript-simple fixture
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| test/replace-around-steps/replace-around-steps.test.ts | Added 4 new skipped test cases for open slice end scenarios, removed commented-out test code, and fixed indentation in one test |
| test/nodes/nodes.test.ts | Updated position indices from 144/145 to 163/164 to match the restructured manuscript-simple fixture |
| test/manuscript/manuscript.test.ts | Updated position indices from 11 to 15 to accommodate the new document structure |
| test/fixtures/manuscript-simple.json | Restructured document to comply with schema requirements by adding wrapper nodes and new required attributes |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
asouqi
commented
Jan 15, 2026
Comment on lines
-69
to
-78
| // This simulates pressing backspace inside 4th paragraph which should try to lift it inside the blockquote | ||
| // .cmd((state, dispatch) => { | ||
| // const { tr, schema } = state | ||
| // const bq = schema.nodes.blockquote.create() | ||
| // // Or, more challenging? | ||
| // // const bq = schema.nodes.blockquote.create(undefined, schema.nodes.paragraph.create()) | ||
| // const slice = new Slice(Fragment.from(bq), 1, 0) | ||
| // const step = new ReplaceAroundStep(48, 64, 49, 64, slice, 0, true) | ||
| // dispatch(tr.step(step)) | ||
| // }) |
Contributor
Author
There was a problem hiding this comment.
this case moved up in a separate test case, and was skipped as we still don't support tracking of joining to the nodes
mbartenev-atypon
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test/__fixtures__/manuscript-simple.jsonas there was an update to manuscript-transform without updating the document to be compatible with the schema