Conversation
mbetamony
commented
Feb 12, 2025
Comment on lines
+48
to
+49
| const journal = JournalProcessor.parse(this.doc) | ||
| return { |
Contributor
Author
There was a problem hiding this comment.
Probably sharing a similar structure to the other parsers would make more sense.
mbetamony
marked this pull request as draft
May 28, 2025 19:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the other concept i've been playing around with, having different parsers for our top levels node. Looking at this PR there are things i'd like to change (go from a class based approach to a more functional approach, i can't see what value these classes bring). But the main idea is the same, to have different parsers and build the article using these parsers.
The starting point here is https://github.com/Atypon-OpenSource/manuscripts-transform/pull/189/files#diff-ae38ba48813b65ce7c70536153b618cfaa8fed2fd8fbff6b58e0f774a8ee9ba9R1-R15
There also seems to be some not needed manipulating to the document, that we can remove i think. Something we can probably take advantage of with this approach
Please let me know your thoughts, and if you prefer any of these two approaches, or if we should just stick with what we have now.
Thanks!