Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces an Attribute-Based Access Control (ABAC) policy layer for ProseMirror manuscript nodes, aimed at preventing unauthorized users from manipulating comment nodes (LEAN-5385).
Changes:
- Added
src/lib/access-control.tsdefining access context/types and acommentnode policy for insert/delete/attribute updates. - Exported the new access-control module from the package entrypoint (
src/index.ts).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/lib/access-control.ts | Adds ABAC policy definitions and policy lookup for protected node types (currently comment). |
| src/index.ts | Exposes the new access-control API via the library’s public exports. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
mbartenev-atypon
approved these changes
Jun 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.