Closed
Conversation
…t found" error in Editor for some items (LEAN-5747)
There was a problem hiding this comment.
Pull request overview
This PR addresses a migration edge case where legacy figcaption data can yield an invalid/unsupported caption structure, which can surface as “Document not found” when opening certain previously-created drafts. It also extends the JATS exporter to optionally include uncited references in the generated <ref-list>.
Changes:
- Update migration
4.3.34to synthesize a minimalcaptionstructure when legacyfigcaptioncontent is missing. - Add a schema test fixture case covering an empty
figcaptionscenario. - Add
includeUncitedReferencesto JATS export options and a test validating the expanded bibliography output.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/schema/migration/migration-scripts/4.3.34.ts | Adjusts how captions are reconstructed from legacy figcaption content during migration. |
| src/schema/tests/docs.ts | Adds a fixture containing an empty figcaption to exercise the migration behavior. |
| src/jats/exporter/jats-exporter.ts | Adds an export option to include uncited bibliography items by passing uncited IDs into citeproc state rebuild. |
| src/jats/tests/jats-exporter.test.ts | Adds test coverage for exporting uncited references when the new option is enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+65
to
+81
| const foundCaption = | ||
| captionNodes.length === 0 | ||
| ? { | ||
| type: 'caption', | ||
| content: [{ type: 'text_block', attrs: {} }], | ||
| attrs: {}, | ||
| } | ||
| : captionNodes.reduce<JSONProsemirrorNode>( | ||
| (caption, { content }) => ({ | ||
| ...caption, | ||
| content: [ | ||
| ...(caption.content || []), | ||
| { type: 'text_block', content, attrs: {} }, | ||
| ], | ||
| }), | ||
| { type: 'caption', content: [], attrs: {} } | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.