Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix the native macOS release packaging path so GitHub release assets are generated from a complete, verifiable app bundle instead of an unsigned hand-built bundle.
Root cause
The previous native macOS release DMG contained an app bundle created by copying the Swift executable and writing
Info.plist, but the bundle was never signed at the app bundle level. Gatekeeper saw an invalid resource seal (code has no resources but signature indicates they must be present) and reported the downloaded app as damaged.Changes
StandForge Native.appwithContents/Resources/icon.icns.Validation
npm run mac:native:buildcodesign --verify --deep --strict --verbose=4.hdiutil verify.spctlstill rejects adhoc local builds as expected; release builds require Developer ID signing and notarization secrets.