Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
Timer state was maintained mainly in process memory, so relaunches and delayed ticks could lose or distort session progress. Configuration and lifecycle commands also lacked consistent validation and persistence boundaries. The native client had the same wall-clock/persistence gaps, while the build and UI layers retained unused permissions, dependencies, and components.
Validation
npm test— 5 frontend, 3 Rust, and 3 Swift tests passednpm run buildnpm run tauri build -- --debugnpm run mac:native:buildnpm audit— 0 vulnerabilitiesbash -n native-macos/scripts/build-app.shcodesign --verify --deep --strictfor both generated macOS app bundlesgit diff --checkNotes
The generated bundles use ad-hoc signing for local verification. Developer ID signing and notarization still require the corresponding Apple credentials/profile.