feat(data): add endpoints for set subgraph property data

[robigupt]

add requirements for set subgraph property data

[qualcomm-ai-code-review-assistant]

Files Not Fully Analyzed

• packages/api/src/infrastructure-wrapper/persistence/unit-of-work/typeorm-unit-of-work.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/command-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/query-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/query-services.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/subgraph-property-definition/subgraph-property-def-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/vcpm-definition/vcpm-definition-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/dto/subgraph-write-result-types.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-property/update-subgraph-property.command.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-scenario/update-subgraph-scenario.command.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-vsid/update-subgraph-vsid.command.ts - Full file content skipped due to token limit
• packages/core/src/index.ts - Full file content skipped due to token limit
• packages/infrastructure/persistence/src/persistence-typeorm-sqllite/queries/subgraph-property-definition/db-subgraph-property-def-query-service.ts - Full file content skipped due to token limit
• packages/infrastructure/persistence/src/persistence-typeorm-sqllite/queries/typeorm-query-services.ts - Full file content skipped due to token limit

Qualcomm AI Review

[qualcomm-ai-code-review-assistant]

Files Not Fully Analyzed

• packages/api/src/infrastructure-wrapper/persistence/unit-of-work/typeorm-unit-of-work.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/command-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/query-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/query-services.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/subgraph-property-definition/subgraph-property-def-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/vcpm-definition/vcpm-definition-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/repositories/module/module.repository.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/build-subgraph-with-defaults.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/dto/subgraph-write-result-types.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/get-property/get-subgraph-property.query.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/patch/patch-subgraph.handler.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/subgraph-property-ids/subgraph-property-ids.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-property/update-subgraph-property.command.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-scenario/update-subgraph-scenario.command.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-vsid/update-subgraph-vsid.command.ts - Full file content skipped due to token limit
• packages/core/src/index.ts - Full file content skipped due to token limit
• packages/core/tests/unit/application/usecase-designer/subgraph/build-subgraph-with-defaults.spec.ts - Full file content skipped due to token limit
• packages/infrastructure/persistence/src/persistence-typeorm-sqllite/queries/subgraph-property-definition/db-subgraph-property-def-query-service.ts - Full file content skipped due to token limit
• packages/infrastructure/persistence/src/persistence-typeorm-sqllite/queries/typeorm-query-services.ts - Full file content skipped due to token limit

Qualcomm AI Review

[qualcomm-ai-code-review-assistant]

Files Not Fully Analyzed

• packages/api/src/infrastructure-wrapper/persistence/unit-of-work/typeorm-unit-of-work.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/command-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/query-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/query-services.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/subgraph-property-definition/subgraph-property-def-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/vcpm-definition/vcpm-definition-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/repositories/module/module.repository.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/shared/serialize-elements.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/dto/subgraph-write-result-types.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/subgraph-property-ids/subgraph-property-ids.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-property/update-subgraph-property.command.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-scenario/update-subgraph-scenario.command.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-vsid/update-subgraph-vsid.command.ts - Full file content skipped due to token limit
• packages/core/src/index.ts - Full file content skipped due to token limit
• packages/infrastructure/persistence/src/persistence-typeorm-sqllite/queries/typeorm-query-services.ts - Full file content skipped due to token limit

Qualcomm AI Review

[qualcomm-ai-code-review-assistant]

Files Not Fully Analyzed

• packages/api/src/infrastructure-wrapper/persistence/unit-of-work/typeorm-unit-of-work.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/command-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/query-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/subgraph-property-definition/subgraph-property-def-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/vcpm-definition/vcpm-definition-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/repositories/module/module.repository.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/shared/serialize-elements.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/dto/subgraph-write-result-types.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/subgraph-property-ids/subgraph-property-ids.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-property/update-subgraph-property.command.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-scenario/update-subgraph-scenario.command.ts - Full file content skipped due to token limit
• packages/core/src/index.ts - Full file content skipped due to token limit
• packages/infrastructure/persistence/src/persistence-typeorm-sqllite/queries/subgraph-property-definition/db-subgraph-property-def-query-service.ts - Full file content skipped due to token limit
• packages/infrastructure/persistence/src/persistence-typeorm-sqllite/queries/typeorm-query-services.ts - Full file content skipped due to token limit

Qualcomm AI Review

[qualcomm-ai-code-review-assistant]

Files Not Fully Analyzed

• packages/api/src/infrastructure-wrapper/persistence/unit-of-work/typeorm-unit-of-work.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/command-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/query-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/query-services.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/subgraph-property-definition/subgraph-property-def-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/vcpm-definition/vcpm-definition-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/repositories/module/module.repository.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/shared/serialize-elements.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/dto/subgraph-write-result-types.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/subgraph-property-ids/subgraph-property-ids.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-scenario/update-subgraph-scenario.command.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-vsid/update-subgraph-vsid.command.ts - Full file content skipped due to token limit
• packages/core/src/index.ts - Full file content skipped due to token limit
• packages/infrastructure/persistence/src/persistence-typeorm-sqllite/queries/subgraph-property-definition/db-subgraph-property-def-query-service.ts - Full file content skipped due to token limit
• packages/infrastructure/persistence/src/persistence-typeorm-sqllite/queries/typeorm-query-services.ts - Full file content skipped due to token limit

Qualcomm AI Review

[qualcomm-ai-code-review-assistant]

Files Not Fully Analyzed

• packages/api/src/infrastructure-wrapper/persistence/unit-of-work/typeorm-unit-of-work.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/command-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/query-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/query-services.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/subgraph-property-definition/subgraph-property-def-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/vcpm-definition/vcpm-definition-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/repositories/module/module.repository.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/shared/serialize-elements.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/dto/subgraph-write-result-types.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/get-property/get-subgraph-property.query.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/patch/patch-subgraph.handler.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-property/update-subgraph-property.command.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-scenario/update-subgraph-scenario.command.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-vsid/update-subgraph-vsid.command.ts - Full file content skipped due to token limit
• packages/core/src/index.ts - Full file content skipped due to token limit
• packages/infrastructure/persistence/src/persistence-typeorm-sqllite/queries/subgraph-property-definition/db-subgraph-property-def-query-service.ts - Full file content skipped due to token limit
• packages/infrastructure/persistence/src/persistence-typeorm-sqllite/queries/typeorm-query-services.ts - Full file content skipped due to token limit

Qualcomm AI Review

[qualcomm-ai-code-review-assistant]

Files Not Fully Analyzed

• packages/api/src/infrastructure-wrapper/persistence/unit-of-work/typeorm-unit-of-work.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/command-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/query-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/query-services.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/subgraph-property-definition/subgraph-property-def-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/vcpm-definition/vcpm-definition-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/repositories/module/module.repository.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/shared/serialize-elements.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/dto/subgraph-write-result-types.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/get-property/get-subgraph-property.query.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/patch/patch-subgraph.handler.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/subgraph-property-ids/subgraph-property-ids.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-property/update-subgraph-property.command.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-scenario/update-subgraph-scenario.command.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-vsid/update-subgraph-vsid.command.ts - Full file content skipped due to token limit
• packages/core/src/index.ts - Full file content skipped due to token limit
• packages/infrastructure/persistence/src/persistence-typeorm-sqllite/queries/subgraph-property-definition/db-subgraph-property-def-query-service.ts - Full file content skipped due to token limit
• packages/infrastructure/persistence/src/persistence-typeorm-sqllite/queries/typeorm-query-services.ts - Full file content skipped due to token limit

Qualcomm AI Review

[qualcomm-ai-code-review-assistant]

Files Not Fully Analyzed

• packages/api/src/infrastructure-wrapper/persistence/unit-of-work/typeorm-unit-of-work.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/command-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/query-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/query-services.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/subgraph-property-definition/subgraph-property-def-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/vcpm-definition/vcpm-definition-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/repositories/module/module.repository.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/shared/serialize-elements.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/build-subgraph-with-defaults.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/dto/subgraph-write-result-types.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/patch/patch-subgraph.handler.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/subgraph-property-ids/subgraph-property-ids.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-property/update-subgraph-property.command.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-scenario/update-subgraph-scenario.command.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-vsid/update-subgraph-vsid.command.ts - Full file content skipped due to token limit
• packages/core/src/index.ts - Full file content skipped due to token limit
• packages/infrastructure/persistence/src/persistence-typeorm-sqllite/queries/subgraph-property-definition/db-subgraph-property-def-query-service.ts - Full file content skipped due to token limit
• packages/infrastructure/persistence/src/persistence-typeorm-sqllite/queries/typeorm-query-services.ts - Full file content skipped due to token limit

Qualcomm AI Review

[NithinSimon]

add 2 methods
wipeAllCkvData
wipeAllTkvData

adding zero ckv data is a business logic, it should be in core layer

[NithinSimon]

Don't assign default values if fields have no value.

[NithinSimon]

Is this invalid operation or on invalid input?

[NithinSimon]

Review Findings

1. P1 subgraph.repository.ts:192 looks up new properties only in base tables. A property created earlier in the same edit session cannot receive data because it has not been committed yet. Use the overlay fetcher.
2. P1 subgraph.repository.ts:345 removes VCPM instances only from base rows. An Audio-to-Voice-to-Audio transition in one session leaves pending VCPM CREATE actions intact and commits unwanted VCPM data.
3. P1 update-subgraph-vsid.handler.ts:198 and update-subgraph-scenario.handler.ts:453 continue graph traversal through Audio nodes. A Voice A → Audio B → Voice C chain can incorrectly update or conflict with Voice C. Only enqueue Voice nodes.
4. P2 serialize-elements.ts:458 uses 0 for formula-sized default arrays rather than evaluating arrayLenFormulaStr. Defaults such as count = 2 followed by an array sized by count fail serialization and persist null.
5. P2 update-subgraph-property.handler.ts:32 and patch-subgraph.handler.ts:20 call base-table subgraphExists(). Subgraphs created or deleted in the active edit session are therefore handled incorrectly.

[qualcomm-ai-code-review-assistant]

Files Not Fully Analyzed

• packages/api/src/infrastructure-wrapper/persistence/unit-of-work/typeorm-unit-of-work.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/command-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/orchestration/cqrs/registries/query-handler-registry.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/subgraph-property-definition/subgraph-property-def-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/query-services/vcpm-definition/vcpm-definition-query-service.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/repositories/module/module.repository.ts - Full file content skipped due to token limit
• packages/core/src/application/ports/persistence/repositories/subgraph/subgraph.repository.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/dto/subgraph-write-result-types.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/subgraph-property-ids/subgraph-property-ids.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-property/update-subgraph-property.command.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-scenario/update-subgraph-scenario.command.ts - Full file content skipped due to token limit
• packages/core/src/application/usecase-designer/subgraph/update-vsid/update-subgraph-vsid.command.ts - Full file content skipped due to token limit
• packages/core/src/index.ts - Full file content skipped due to token limit
• packages/infrastructure/persistence/src/persistence-typeorm-sqllite/repositories/subgraph/subgraph.repository.ts - Full file content skipped due to token limit

Qualcomm AI Review

[qualcomm-ai-code-review-assistant]

[FUNCTIONALITY - High] Missing moduleNodeFetcher initialization causes runtime error

The TypeOrmModuleRepository class references this.moduleNodeFetcher in the getModulesBySubgraphId and wipeCalData methods (lines 441-461 and 596-600), but this field is never initialized in the constructor. This will cause a runtime error when these methods are called.

Impact: Any attempt to call getModulesBySubgraphId or wipeCalData will result in a TypeError: "Cannot read property 'loadBaselineNodeIdsForSubgraph' of undefined".

Fixed Code Snippet

export class TypeOrmModuleRepository implements ModuleRepository {
  private readonly spfModuleFetcher: SpfModuleOverlayFetcher;
  private readonly nodeFetcher: NodeOverlayFetcher;
  private readonly portFetcher: PortOverlayFetcher;
  private readonly ckvOverlayFetcher: CkvOverlayFetcher;
  private readonly tkvOverlayFetcher: TkvOverlayFetcher;
  private readonly moduleNodeFetcher: ModuleNodeFetcher; // Add this field

  constructor(
    private readonly writer: PendingChangeWriter,
    private readonly manager: EntityManager,
    private readonly uow: UnitOfWork,
  ) {
    const editActionsQs = new EditActionsQueryService(manager);
    this.spfModuleFetcher = new SpfModuleOverlayFetcher(manager, editActionsQs);
    this.nodeFetcher = new NodeOverlayFetcher(manager, editActionsQs);
    this.portFetcher = new PortOverlayFetcher(
      manager,
      editActionsQs,
      new IntentFetcher(manager, editActionsQs),
    );
    this.ckvOverlayFetcher = new CkvOverlayFetcher(
      manager,
      editActionsQs,
      new CkvParameterPayloadFetcher(manager, editActionsQs),
    );
    this.tkvOverlayFetcher = new TkvOverlayFetcher(manager, editActionsQs);
    this.moduleNodeFetcher = new ModuleNodeFetcher(manager, editActionsQs); // Initialize here
  }

[qualcomm-ai-code-review-assistant]

[PERFORMANCE - Medium] Potential N+1 query pattern in module calibration wipe

In the wipeCalData method of TypeOrmModuleRepository (lines 464-508), the writeZeroCkvResets method iterates over resets and calls writeDelta for each one sequentially (lines 735-747). This creates N separate database operations instead of batching them.

Impact: For modules with many parameters, this could result in hundreds of individual database writes, significantly impacting performance during scenario transitions.

Fixed Code Snippet

private async writeZeroCkvResets(
  resets: Array<{payloadSystemId: number; defaultValue: Uint8Array | null}>,
  zeroCkvSystemId: number | undefined,
  moduleSystemId: number,
  sessionId: number,
  groupId: string,
): Promise<number[]> {
  if (!zeroCkvSystemId || resets.length === 0) return [];
  
  // Batch all payload updates into a single operation
  await this.writer.writeDeltaBatch(
    resets.map(reset => ({
      targetTable: ENTITY_NAMES.CkvParameterPayload,
      targetSystemId: reset.payloadSystemId,
      aggregateId: moduleSystemId,
      delta: {payload: reset.defaultValue},
    })),
    sessionId,
    groupId,
    this.manager,
  );
  
  return [zeroCkvSystemId];
}