Conversation
tmohakul
force-pushed
the
refactor-edit-session
branch
from
September 8, 2026 14:09
d49e56e to
607927e
Compare
NithinSimon
reviewed
Sep 8, 2026
|
|
||
| // ── Subsystem / UseCase ─────────────────────────────────────────────────── | ||
| Subsystem: 'Subsystem', | ||
| SubsystemFilteredKey: 'SubsystemFilteredKey', |
Contributor
There was a problem hiding this comment.
Is this the table holding keys assigned to subsystem?
Contributor
Author
There was a problem hiding this comment.
yes , it stores subsystem system ID → key-definition system IDs
tmohakul
force-pushed
the
refactor-edit-session
branch
from
September 9, 2026 07:57
607927e to
e1e85e0
Compare
Add the subsystem-filtered usecase query endpoint as an extension of the existing usecase query API: GET /arc-api/v1/projects/:projectId/usecases/filtered-by-subsystem Reuse existing usecase filters and edit-session overlays. Apply nested subsystem filtered-GKV transformation. Group usecases with identical filtered GKV values. Reuse NodeOverlayFetcher for effective topology. Support shared subgraphs, hierarchy-root handling, and raw-GKV fallback. Signed-off-by: Tapan Mohakul <tmohakul@qti.qualcomm.com>
tmohakul
force-pushed
the
refactor-edit-session
branch
from
September 9, 2026 17:06
e1e85e0 to
78869af
Compare
aboppay
reviewed
Sep 10, 2026
| Manual = 'Manual', | ||
| } | ||
|
|
||
| export class SubsystemFilteredKvDto { |
Contributor
There was a problem hiding this comment.
This should be defined as zod schema in Core right?
aboppay
reviewed
Sep 10, 2026
| }; | ||
| } | ||
|
|
||
| function toApiUsecase(uc: UseCaseReadModel) { |
Contributor
There was a problem hiding this comment.
this dto should be returned from core handler.
aboppay
reviewed
Sep 10, 2026
| '- Parentheses for grouping: `subsystemId:value1 AND (subsystemId:value2 OR subsystemId:value3)`\n\n' + | ||
| '**Valid Fields:**\n' + | ||
| '- `subsystemId`: Subsystem system ID (only field supported by this endpoint)\n\n' + | ||
| '- `subsystemId`: Subsystem system ID\n' + |
Contributor
There was a problem hiding this comment.
filter is on natural ids only, lets fix comment and implementation
aboppay
reviewed
Sep 10, 2026
| // 4. Return organized hierarchy | ||
| const query = new GetSubsystemFilteredUsecasesQuery( | ||
| parsedProjectId, | ||
| 'client-id', // TODO: get actual clientId from JWT |
Contributor
There was a problem hiding this comment.
authentication is already enabled, check other APIs and use accordingly.
aboppay
reviewed
Sep 10, 2026
| if (!subsystem) continue; | ||
| filteredGkv.push({ | ||
| key: { | ||
| systemId: SUBSYSTEM_FILTERED_KEY_ID, |
Contributor
There was a problem hiding this comment.
systemId doesnt make sense for subsystem. Should we use different dto to send back this info?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the subsystem-filtered usecase query endpoint as an extension of the existing usecase query API:
GET /arc-api/v1/projects/:projectId/usecases/filtered-by-subsystem