Skip to content

Add CI/CD gating overview to CONTRIBUTING guide - #101

Open
quic-aditrath wants to merge 1 commit into
AudioReach:masterfrom
quic-aditrath:add-cicd-gating-section
Open

quic-aditrath wants to merge 1 commit into
AudioReach:masterfrom
quic-aditrath:add-cicd-gating-section

Conversation

@quic-aditrath

Copy link
Copy Markdown
Contributor

Document the automated checks that run against every pull request so contributors know what to expect and how to react when a check fails.

Add a CI/CD Gating section covering Pre-flight Checks, Build Gating, and Run-time Validation, and a short note on reviewing job logs and pushing fixes to re-trigger the pipeline on failure.

Document the automated checks that run against every pull request so
contributors know what to expect and how to react when a check fails.

Add a CI/CD Gating section covering Pre-flight Checks, Build Gating,
and Run-time Validation, and a short note on reviewing job logs and
pushing fixes to re-trigger the pipeline on failure.

Signed-off-by: Aditya Rathi <aditrath@qti.qualcomm.com>
@quic-aditrath
quic-aditrath requested review from a team August 25, 2026 05:55
@qualcomm-ai-code-review-assistant

Copy link
Copy Markdown

Qualcomm AI Review

Click to expand Code Review
Reviewed Commits: f8e9da3
  • f8e9da3: Add CI/CD gating overview to CONTRIBUTING guide

Document the automated checks that run against every pull request so
contributors know what to expect and how to react when a check fails.

Add a CI/CD Gating section covering Pre-flight Checks, Build Gating,
and Run-time Validation, and a short note on reviewing job logs and
pushing fixes to re-trigger the pipeline on failure.

Signed-off-by: Aditya Rathi aditrath@qti.qualcomm.com

PR Overview

This PR adds comprehensive CI/CD documentation to the CONTRIBUTING.md file, explaining the automated checks and gating processes that run on pull requests.

Files Changed Summary

File Lines Added Lines Removed Issues Found Highest Severity
CONTRIBUTING.md 29 0 1 Low

Changes Summary

The PR adds a new "CI/CD Gating" section (lines 30-57) that documents:

  • Pre-flight checks (static analysis, security scanning, compliance validation)
  • Build gating process
  • Run-time validation on LAVA board-farm
  • Guidance for handling check failures

Issues Identified

  1. [MAINTAINABILITY] Typo in documentation (Low severity) - Line 17 contains a spelling error that should be corrected for professional documentation quality.

Overall Assessment

This is a documentation-only change that significantly improves contributor experience by clearly explaining the CI/CD pipeline. The content is well-structured and informative. Only one minor typo was identified.

[MAINTAINABILITY] Spelling error in DCO commit instruction - Low Severity

Line 17 contains a spelling error: 'commiting' should be 'committing'. This is a minor typo in the documentation that affects professional presentation.

Fixed Code Snippet:

1. Commit your changes using the [DCO](http://developercertificate.org/). You can attest to the DCO by committing with the **-s** or **--signoff** options or manually adding the "Signed-off-by":

⚠️ This review was generated using AI assistance. Please verify all suggestions before applying.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error Summary

All 1 suggested inline comments were outside the diff context and were skipped

Qualcomm AI Review

Comment thread CONTRIBUTING.md

### Run-time Validation

Runs automatically after a successful build gate. Applicable targets are dispatched to a LAVA board-farm for on-device testing, so we catch issues that only surface at runtime. Results are posted back to the PR. If the build gate fails or is skipped, run-time validation won't run.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should mention about sequence of event, checker -> public CI -> maintainer approval -> internal CI -> merge, go over what to do if Qualcomm internal CI fails, how to approach maintainer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants