Conversation
|
CC @qti-sbojja |
|
@slyon , please clear the checks. |
66b4cd2 to
5135548
Compare
@rchiluka29 Done: Fixed the commit-message checks. The other CI failures seem to be unrelated to this change. |
|
@rchiluka29 , please help to update lib names for dependent packages. |
Rename Autotools and Android shared-library targets from libar-* to libaudioreach-* and update all internal dependencies and ABI-check paths. Keep the pkg-config package names and filenames stable while updating their Libs entries, so pkg-config consumers continue to resolve the libraries after the rename. Fixes: http://github.com/AudioReach/audioreach-graphservices/issues/110 Signed-off-by: Lukas Märdian <lukas.maerdian@oss.qualcomm.com>
SPF contains only headers, so install them directly without generating the empty libaudioreach-spfhdrs shared object. Remove GSLs dependency on the target and make spf.pc header-only while retaining its pkg-config include flags. Fixes: http://github.com/AudioReach/audioreach-graphservices/issues/104 Signed-off-by: Lukas Märdian <lukas.maerdian@oss.qualcomm.com>
5135548 to
e672de7
Compare
Ideally, it should be consumed via |
AudioReach/audioreach-pal#87 Made changes implemented it properly in above both repos on using by pkg-config rather than name swap. |
|
I see the "CRs-Fixed" tag has already been added to the PR description. Thank you for driving those changes in |
|
@quic-aditrath can you please review and merge. And pal change also. |
3 participants
Rename Autotools and Android shared-library targets from libar-* to libaudioreach-* and update all internal dependencies and ABI-check paths.
Keep the pkg-config package names and filenames stable while updating their Libs entries, so pkg-config consumers continue to resolve the libraries after the rename.
The rationale behind this change is that the "ar" in "libar-" stands for "AudioReach", but can be easily confused with binutils' ar archive format. We might consider spelling it out as libaudioreach-.so.1, so that we do not get into any namespace conflicts (or confusion), when integrating the project with a general purpose Linux distribution, such as Debian.
Fixes: #110
In addition to that, we're dropping the empty
libaudioreach-spfhdrs.solibrary. SPF contains only headers, so install them directly without generating the empty libaudioreach-spfhdrs shared object. Remove GSLs dependency on the target and makespf.pcheader-only while retaining its pkg-config include flags.Fixes: #104
CRs-Fixed: 4673839