Fix capture and playback concurrency issue - #19
Merged
Merged
Conversation
mohsRafi
reviewed
Nov 5, 2025
mohsRafi
reviewed
Nov 5, 2025
mohsRafi
reviewed
Nov 5, 2025
mohsRafi
reviewed
Nov 5, 2025
RaviHothi
force-pushed
the
master
branch
2 times, most recently
from
November 6, 2025 07:09
8a44b03 to
e77b615
Compare
nandamajay
approved these changes
Nov 6, 2025
quic-plai
reviewed
Nov 17, 2025
The existing implementation lacks proper handling for concurrent enablement of capture and playback. Replace FIFO-based port backup with idr-based mapping. This change introduces a new implementation for backing up src/dst ports using idr_alloc() to associate the mapping with a unique token. The previous FIFO-based mechanism has been removed to simplify the logic and avoid race conditions during port restoration. The callback now retrieves the port mapping via idr_find() and restores the ports accordingly. Signed-off-by: Ravi Hothi <ravi.hothi@oss.qualcomm.com>
quic-plai
approved these changes
Nov 20, 2025
quic-aditrath
approved these changes
Nov 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing implementation lacks proper handling for concurrent enablement of capture and playback. This update introduces a new implementation to address and resolve the concurrency issue.