audioreach-driver: fix const-correctness and header rewrite - #53
Merged
Merged
Conversation
The GPR core updated the callback API to use a const-qualified packet type. Update the q6apm and q6prm callbacks to match the new signature. The earlier code modified fields in the inbound GPR packet header, which is now const. Copy the packet buffer and apply port remapping only to the local copy. Signed-off-by: Aiyaz Patel <aiyapate@qti.qualcomm.com>
aiyapate
force-pushed
the
const_func_ptr_fix
branch
from
March 4, 2026 05:49
29784c7 to
0c683e6
Compare
nandamajay
approved these changes
Mar 4, 2026
quic-aditrath
approved these changes
Mar 4, 2026
qti-sbojja
approved these changes
Mar 4, 2026
|
Merge Check Failed: No CR Numbers Found Error: No Change Request numbers were found. Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests. |
1 similar comment
|
Merge Check Failed: No CR Numbers Found Error: No Change Request numbers were found. Please add Change Request numbers to your pull request description in the format CRs-Fixed: 12345 or link GitHub issues that are associated with Change Requests. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The GPR core updated the callback API to use a const-qualified packet type. Update the q6apm and q6prm callbacks to match the new signature.
The earlier code modified fields in the inbound GPR packet header, which is now const. Copy the packet buffer and apply port remapping only to the local copy.