pal: vui_interface: fix SPF_CFLAGS in sva_intf Makefile.am - #88
Merged
Merged
Conversation
kvijayas
changed the title
sva_intf/Makefile.am references @SPF_CFLAGS@, but configure.ac only defines SPFHEADER_CFLAGS via PKG_CHECK_MODULES([SPFHEADER],[spf]). Since SPF_CFLAGS is never registered with AC_SUBST. Replace @SPF_CFLAGS@ with @SPFHEADER_CFLAGS@, matching the already-correct usage in customva_intf/Makefile.am and hotword_intf/Makefile.am. Signed-off-by: kvijayas <kvijayas@qti.qualcomm.com>
qti-sbojja
approved these changes
Sep 12, 2026
quic-aditrath
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
## Summary
sva_intf/Makefile.am uses
@SPF_CFLAGS@, but configure.ac neverAC_SUBSTs a variable by that name — only
SPFHEADER_CFLAGSexists,via
PKG_CHECK_MODULES([SPFHEADER],[spf]).## Fix
Replace
@SPF_CFLAGS@with@SPFHEADER_CFLAGS@, matching thealready-correct usage in customva_intf/Makefile.am and
hotword_intf/Makefile.am.
CRs-Fixed: 4675356