Normalize the S3 location prefix before building artifact paths and Harden aws-s3-exchanger shell execution and file handling - #77
Merged
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
svutukur20
previously approved these changes
Jul 30, 2026
Append a trailing slash only when the location input is provided. Reuse the normalized prefix for upload, download, and presign operations. Prevent creation of empty S3 path segments when location is unset. Signed-off-by: ffrancis <ffrancis@qti.qualcomm.com>
svutukur20
previously approved these changes
Jul 30, 2026
ffrancis123
force-pushed
the
s3
branch
3 times, most recently
from
July 31, 2026 09:21
9bc71ad to
dc2cfaa
Compare
ffrancis123
changed the title
ffrancis123
force-pushed
the
s3
branch
2 times, most recently
from
July 31, 2026 10:02
b4ddaf2 to
21a6972
Compare
Move GitHub expressions out of shell blocks and consume inputs through environment variables. Normalize location prefixes, enable strict shell mode, create URL artifact directories, and apply safer file permissions while preserving SDK script executability. Signed-off-by: ffrancis <ffrancis@qti.qualcomm.com>
svutukur20
approved these changes
Jul 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commits included:
Normalize the S3 location prefix before building artifact paths
Harden aws-s3-exchanger shell execution and file handling