fix: validate classic SAP object workflows and simulator - #5
Merged
Conversation
Augusto42
marked this pull request as ready for review
August 17, 2026 16:44
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
objectTypefilter to the server so filtered searches respect--max.abapcontent detection for programs and includesvsp source writeWhy
The object-type expansion worked in isolated mocks but uncovered compatibility gaps on an SAP NetWeaver 7.52 learning system. In particular, optional HANA/abapGit classes blocked the APC handler, DDIC table types were wrapped incorrectly for RFC calls, classic enhancement includes may use padded technical names, and CLI type filtering happened after ADT had already limited the page.
Impact
The fork can now install its core bridge on classic SAP systems and perform read-only Dynpro and Enhancement workflows more reliably. Optional domains are advertised only when their services are actually available.
Validation
go test ./...go vet ./...go build ./cmd/vspsearch '*' --type ENHO --max 10returned 10 typed resultsgit diff --checkAll fixtures are synthetic, and the live validation used only standard SAP learning-system objects. No customer data or credentials are included.