Skip to content

fix: validate classic SAP object workflows and simulator - #5

Merged
Augusto42 merged 2 commits into
mainfrom
codex/mock-sap-e2e
Aug 17, 2026
Merged

fix: validate classic SAP object workflows and simulator#5
Augusto42 merged 2 commits into
mainfrom
codex/mock-sap-e2e

Conversation

@Augusto42

@Augusto42 Augusto42 commented Aug 15, 2026

Copy link
Copy Markdown
Owner

What changed

  • adds a localhost-only SAP ADT/ZADT_VSP protocol simulator
  • makes AMDP and abapGit services optional so the APC handler activates on classic non-HANA systems
  • fixes dynamic RFC table creation used by real Dynpro reads
  • resolves classic HOOK_IMPL source includes through ENHINCINX for ENHO reads
  • sends the ADT objectType filter to the server so filtered searches respect --max
  • fixes generic .abap content detection for programs and includes
  • exposes create/update/upsert metadata flags in vsp source write
  • improves installer syntax diagnostics

Why

The object-type expansion worked in isolated mocks but uncovered compatibility gaps on an SAP NetWeaver 7.52 learning system. In particular, optional HANA/abapGit classes blocked the APC handler, DDIC table types were wrapped incorrectly for RFC calls, classic enhancement includes may use padded technical names, and CLI type filtering happened after ADT had already limited the page.

Impact

The fork can now install its core bridge on classic SAP systems and perform read-only Dynpro and Enhancement workflows more reliably. Optional domains are advertised only when their services are actually available.

Validation

  • go test ./...
  • go vet ./...
  • go build ./cmd/vsp
  • localhost-only mock SAP end-to-end coverage
  • real local SAP 7.52 lab: Dynpro read returned header and flow logic
  • real local SAP 7.52 lab: ENHO read resolved the padded source include
  • real local SAP 7.52 lab: search '*' --type ENHO --max 10 returned 10 typed results
  • git diff --check

All fixtures are synthetic, and the live validation used only standard SAP learning-system objects. No customer data or credentials are included.

@Augusto42 Augusto42 changed the title test: add synthetic SAP protocol simulator fix: validate classic SAP object workflows and simulator Aug 17, 2026
@Augusto42
Augusto42 marked this pull request as ready for review August 17, 2026 16:44
@Augusto42
Augusto42 merged commit bbde3ff into main Aug 17, 2026
2 checks passed
@Augusto42
Augusto42 deleted the codex/mock-sap-e2e branch August 17, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant