Repository navigation
Conversation
✅ Deploy Preview for jautoo ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request significantly improves the release automation and quality gates for native desktop builds, focusing on adding robust signing, notarization, and verification steps for both Windows and macOS installers. It also introduces a comprehensive set of project checks for all platforms, and updates the release notes to reflect these enhancements.
Release workflow enhancements:
The desktop release workflow (
.github/workflows/desktop-release.yml) now includes steps to sign Windows installers with Authenticode and macOS installers with a Developer ID certificate, followed by Apple notarization and stapling. It also verifies signatures and performs smoke tests on both platforms before publishing. Additionally, SHA-256 checksums are generated and uploaded with the release assets.A new validation job ensures that all required signing and notarization credentials are present before building release artifacts, reducing the risk of incomplete or insecure releases.
Quality and CI improvements:
.github/workflows/checks.yml) is added to enforce project checks on pull requests and pushes. It runs dependency audits, linting, tests, type checks, and builds for both web and desktop projects, as well as formatting and building checks for native code on Windows and macOS.Documentation updates:
.github/release-notes/desktop.md) are updated to clearly state that all installers are now signed and notarized, and that SHA-256 checksums are provided for verification.