fix(terminal): off-by-one in terminal_set_cursor bounds check - #107
Merged
im-nymii merged 1 commit intoJul 24, 2026
Merged
Conversation
x == VGA_WIDTH and y == VGA_HEIGHT passed the check, so the next terminal_putentryat() could write at index row * 80 + 80 -- one cell past the end of the line, and past the end of the VGA text buffer when already on the last row.
Contributor
Author
PoC
if (x > VGA_WIDTH) x = VGA_WIDTH - 1; // 80 > 80 is false -> x stays 80
if (y > VGA_HEIGHT) y = VGA_HEIGHT - 1; // 25 > 25 is false -> y stays 25The ANSI drives The VGA text buffer holds |
Member
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
x == VGA_WIDTHandy == VGA_HEIGHTpassed the check, so the nextterminal_putentryat()could write at indexrow * 80 + 80-- one cell past the end of the line, and past the end of the VGA text buffer when already on the last row.