fix(ansi): u16 overflow on oversized CSI parameters - #108
Merged
Conversation
The CSI parameter accumulator multiplied and added with no overflow protection. A sequence like ESC[99999m overflows the u16 parameter and, since the Zig objects are built with -O ReleaseSafe, trips the safety check and lands in the panic handler: the kernel silently freezes. Use saturating arithmetic so oversized parameters clamp to 65535 instead of bringing the machine down.
Contributor
Author
PoCThe CSI parameter accumulator has no overflow guard: val.params[val.param_index] = (val.params[val.param_index] * 10) + n;
Fix uses saturating arithmetic ( |
Member
|
LGTM ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The CSI parameter accumulator multiplied and added with no overflow protection. A sequence like
ESC[99999moverflows the u16 parameter and, since the Zig objects are built with-O ReleaseSafe, trips the safety check and lands in the panic handler: the kernel silently freezes. Saturating arithmetic clamps oversized parameters to 65535 instead of bringing the machine down.