feat(shell): add reboot and poweroff commands - #115
Merged
Conversation
Adds two machine lifecycle commands. Until now the only way to leave the shell was crash, which just halts. - reboot waits for the 8042 input buffer to drain, then pulses the CPU reset line via outb(0x64, 0xFE). - poweroff triggers an ACPI shutdown through the ports QEMU (0x604) and older QEMU / Bochs (0xB004) expose, which cleanly powers the VM off. Adds a 16-bit outw helper to io.h for the ACPI writes. Both fall back to a halt if the hardware action does not fire.
Member
|
LGTM after review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds two machine lifecycle commands. Until now the only way to leave the shell was crash, which just halts the CPU.
reboot waits for the 8042 input buffer to drain, then pulses the CPU reset line with outb(0x64, 0xFE).
poweroff triggers an ACPI shutdown through the ports QEMU (0x604) and older QEMU / Bochs (0xB004) expose, which cleanly powers the VM off.
Both fall back to a halt if the hardware action does not fire. Also adds a 16-bit outw helper to io.h for the ACPI writes.
Note: poweroff relies on the virtual ACPI device, so it powers off under QEMU/Bochs (their whole workflow); on real hardware a proper ACPI implementation would be needed, there it just halts.
Built and tested locally with the CI setup (Zig 0.16.0 + NASM, USE_ZIG path) in QEMU: