Skip to content

Single workflow#5

Draft
arkiev wants to merge 68 commits into
mainfrom
single_workflow
Draft

Single workflow#5
arkiev wants to merge 68 commits into
mainfrom
single_workflow

Conversation

@arkiev

@arkiev arkiev commented Mar 19, 2026

Copy link
Copy Markdown

The primary contribution of this fork is the addition of a complete DWI preprocessing and QC pipeline integrated as a first-class stage alongside the existing native contrast workflow. This includes automatic DICOM series classification, phase-encoding correction mode selection (rpe_none, rpe_pair, rpe_all, rpe_split), FSL-based DWI preprocessing via dwifslpreproc, tensor fitting to produce ADC and FA maps, and rigid-body T1-to-DWI coregistration using FLIRT — all orchestrated through a new pipeline.py entry point that runs all three stages from a single command. Several refinements were also made to the existing codebase: the ANTs registration check threshold was updated, vial masks are now transformed with nearest-neighbour interpolation to preserve binary values, and the ADC scatter plot was redesigned with open-circle reference markers plotted over the measured values for clearer visual comparison against SPIRIT reference data.

@arkiev arkiev requested a review from tclose March 19, 2026 23:26
@wiz-788c0877ba

wiz-788c0877ba Bot commented Mar 19, 2026

Copy link
Copy Markdown

Wiz Scan Summary

Scanner Findings
Vulnerability Finding Vulnerabilities -
Data Finding Sensitive Data -
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations 1 High 11 Medium 5 Low
SAST Finding SAST Findings 3 Medium
Software Management Finding Software Management Findings -
Total 1 High 14 Medium 5 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

arkiev added 3 commits March 20, 2026 10:50
…API change (plugin → worker) and Click's automatic underscore-to-hyphen conversion in option names (--metric_dir → --metric-dir).
@arkiev arkiev marked this pull request as ready for review March 20, 2026 01:49
@codecov-commenter

codecov-commenter commented Mar 20, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 12.84185% with 3665 lines in your changes missing coverage. Please review.
✅ Project coverage is 20.93%. Comparing base (3216caf) to head (c74fcb0).

Files with missing lines Patch % Lines
phantomkit/dwi_processing.py 0.00% 948 Missing ⚠️
phantomkit/phantom_processor.py 0.00% 717 Missing ⚠️
phantomkit/pipeline.py 0.00% 461 Missing ⚠️
phantomkit/plotting/calibration_plotter.py 14.57% 251 Missing and 1 partial ⚠️
phantomkit/plotting/compare_plots.py 10.94% 179 Missing ⚠️
phantomkit/plotting/vial_intensity.py 36.71% 149 Missing and 13 partials ⚠️
phantomkit/cli.py 14.58% 123 Missing ⚠️
phantomkit/plotting/_calibration_reference.py 0.00% 114 Missing ⚠️
phantomkit/plotting/_html_common.py 53.27% 104 Missing and 10 partials ⚠️
phantomkit/plotting/dwi_html.py 8.25% 100 Missing ⚠️
... and 11 more

❌ Your patch status has failed because the patch coverage (12.84%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##             main       #5       +/-   ##
===========================================
- Coverage   68.73%   20.93%   -47.81%     
===========================================
  Files          12       26       +14     
  Lines        1206     5115     +3909     
  Branches      110      730      +620     
===========================================
+ Hits          829     1071      +242     
- Misses        350     4001     +3651     
- Partials       27       43       +16     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

arkiev and others added 30 commits April 22, 2026 13:35
Replaces the 5 separate per-metric CSV files (mean/median/std/min/max)
per contrast with a single .xlsx file containing one sheet per metric,
stored in metrics/xlsx/ instead of metrics/csv/.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants