Repository navigation
feat(skins): servers follow the platform's skins; esports mode per tournament - #752
Merged
Merged
Conversation
…urnament Skins showed on the platform but never in the game (2026-10-12): every server needed its own switch and had its skins plugin off. - While the platform's skins are on, every server's skins plugin is on and gets the players' loadouts when they connect; switching skins on or off in the settings reaches every connected server at once (syncSkinsPluginEverywhere). The per-server switch is gone. - A tournament can turn on Esports mode (setup → match settings): its matches play Ready Up's `valve` ruleset (rules.ruleset), Valve's competitive rules with the skins plugin inert. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Turning it off is the admin switching skins off (syncSkinsPluginEverywhere), never a side effect of a server connecting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From tonight's test: skins were on in the platform but never appeared in-game (servers had the skins plugin disabled and a per-server switch off).
pluginsSetFor(…, skinsOn)keeps the skins plugin on whileskins_config.enabled; servers without a stored plugin set getplugins.set {enable:['skins']}on hello; toggling skins in settings runssyncSkinsPluginEverywhere()on all connected servers.skinsTargetno longer needscs2_servers.skins; the per-server switch is removed from the server dialog.settings.cs2.esportsMode(toggle under match settings, en + nb); the match config carriesesports: trueandassignConfigsendsrules.ruleset = 'valve'(Ready Up: Valve rules, skins plugin inert).🤖 Generated with Claude Code