Skip to content

fix: replace string slicing with startswith method #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonarqube-agent wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: replace string slicing with startswith method #186

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions discord/activity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -529,7 +529,7 @@ def twitch_name(self) -> Optional[str]:
except KeyError:
return None
else:
return name[7:] if name[:7] == 'twitch:' else None
return name[7:] if name.startswith('twitch:') else None

def to_dict(self) -> Dict[str, Any]:
ret: Dict[str, Any] = {
Expand Down Expand Up @@ -684,7 +684,7 @@ def album(self) -> str:
def album_cover_url(self) -> str:
""":class:`str`: The album cover image URL from Spotify's CDN."""
large_image = self._assets.get('large_image', '')
if large_image[:8] != 'spotify:':
if not large_image.startswith('spotify:'):
return ''
album_image_id = large_image[8:]
return 'https://i.scdn.co/image/' + album_image_id
Expand Down