Skip to content

fix: resolve 5 SonarQube code quality issues #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sonarqube-agent wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: resolve 5 SonarQube code quality issues #5

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions scripts/notebook_validator.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -878,11 +878,7 @@ def cmd_drift(args: argparse.Namespace) -> int:
print(f"FAIL: {update_script} not found", file = sys.stderr)
return 2
# Stash any pre-existing dirty state, run the updater, diff, restore.
head = (
subprocess.check_output(["git", "rev-parse", "HEAD"], cwd = nbdir)
.decode()
.strip()
)
subprocess.check_output(["git", "rev-parse", "HEAD"], cwd = nbdir)
subprocess.run(
["git", "-C", str(nbdir), "stash", "--include-untracked"],
check = False,
Expand Down
4 changes: 2 additions & 2 deletions unsloth/models/rl_replacements.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1871,7 +1871,7 @@ def openenv_vllm_reload_weights():
try:
import trl.experimental.openenv.utils as openenv_utils
import trl.experimental.openenv as openenv
except (ImportError, NameError, Exception) as e:
except Exception as e:
logger.info(f"Unsloth: Failed to import trl openenv: {e}")
logger.info(
"Unsloth: trl.experimental.openenv not available — skipping RL openenv patches."
Expand Down Expand Up @@ -1951,7 +1951,7 @@ def vllm_generation_init_patch():

try:
import trl.generation.vllm_generation as vllm_generation
except (ImportError, NameError, Exception) as e:
except Exception as e:
logger.info(f"Unsloth: Failed to import trl.generation.vllm_generation: {e}")
return

Expand Down
Loading