Resolve function nesting depth and constructor async operations

src/features/lightspeed/base.ts

@@ -89,6 +89,7 @@
       context,
       settingsManager,
     );
+    this.statusBarProvider.updateLightSpeedStatusbar();
 
     this.lightspeedExplorerProvider = new LightspeedExplorerWebviewViewProvider(
       context.extensionUri,

src/features/lightspeed/feedbackWebviewProvider.ts

@@ -86,7 +86,7 @@ export class LightspeedFeedbackWebviewProvider {
     return getWebviewContent(webview, extensionUri);
   }
 
-  private async _setWebviewMessageListener(webview: Webview) {
-    await setWebviewMessageListener(webview, this._disposables);
+  private _setWebviewMessageListener(webview: Webview) {
+    setWebviewMessageListener(webview, this._disposables);
   }
 }

src/features/lightspeed/statusBar.ts

@@ -29,7 +29,6 @@ export class LightspeedStatusBar {
     this.settingsManager = settingsManager;
     // create a new project lightspeed status bar item that we can manage
     this.statusBar = this.initialiseStatusBar();
-    this.updateLightSpeedStatusbar();
   }
 
   private initialiseStatusBar(): vscode.StatusBarItem {

src/features/lightspeed/utils/scanner.ts

@@ -69,6 +69,22 @@ export class CollectionFinder {
     return j;
   }
 
+  private async readCollectionsFromNamespace(
+    namespaceDirectory: string,
+  ): Promise<(AnsibleCollection | null)[]> {
+    const collectionDirectories = await readdir(namespaceDirectory, {
+      withFileTypes: true,
+    });
+    const collectionPromises = collectionDirectories
+      .filter((entry) => entry.isDirectory())
+      .map((entry) =>
+        this.readCollectionMetaInformation(
+          path.join(entry.parentPath, entry.name),
+        ),
+      );
+    return Promise.all(collectionPromises);
+  }
+
   async searchNestedCollections() {
     const collectionsPath = path.join(
       this.workspacePaths[0],
@@ -79,35 +95,25 @@ export class CollectionFinder {
         return namespaceDirectories
           .filter((namespaceEntry) => namespaceEntry.isDirectory())
           .map((namespaceEntry) => {
-            const namespaceName = namespaceEntry.name;
             const namespaceDirectory = path.join(
               namespaceEntry.parentPath,
-              namespaceName,
-            );
-            return readdir(namespaceDirectory, { withFileTypes: true }).then(
-              (collectionDirectories: Dirent[]) => {
-                return collectionDirectories
-                  .filter((entry) => entry.isDirectory())
-                  .map((entry) =>
-                    this.readCollectionMetaInformation(
-                      path.join(entry.parentPath, entry.name),
-                    ),
-                  );
-              },
+              namespaceEntry.name,
             );
+            return this.readCollectionsFromNamespace(namespaceDirectory);
           });
       })
       .catch((e) => {
         console.debug(`Cannot open directory ${collectionsPath}: ${e}`);
         return [];
       });
     const r: AnsibleCollection[] = [];
-    for (let i = 0; i < a.length; i++) {
-      (await Promise.all(await a[i])).forEach((entry) => {
+    for (const namespacePromise of a) {
+      const entries = await namespacePromise;
+      for (const entry of entries) {
         if (entry instanceof AnsibleCollection) {
           r.push(entry);
         }
-      });
+      }
     }
     return r;
   }

test/helper.ts

@@ -10,8 +10,8 @@ import { LIGHTSPEED_ME_AUTH_URL } from "../src/definitions/lightspeed";
 import { getInlineSuggestionItems } from "../src/features/lightspeed/inlineSuggestions";
 import { rmSync } from "fs";
 
-export let doc: vscode.TextDocument;
-export let editor: vscode.TextEditor;
+let doc: vscode.TextDocument;
+let editor: vscode.TextEditor;
 
 export const FIXTURES_BASE_PATH = path.join("test", "testFixtures");
 export const ANSIBLE_COLLECTIONS_FIXTURES_BASE_PATH = path.resolve(