Skip to content

Correct the usage of getConfiguration('autolispext') by modify the extensionDevelopmentPath #141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
nigma456 wants to merge 5 commits into from
Closed

Correct the usage of getConfiguration('autolispext') by modify the extensionDevelopmentPath #141

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
9df9eec
Test the configuration update
May 6, 2021
6df2094
using autolispext.format instead of format
May 6, 2021
40fe018
Correct the extensionDevelopmentPath
May 7, 2021
7800513
Remove the mock method for formatter test
May 7, 2021
a3d850b
Add Semicolon
May 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .vscode/launch.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@
"preLaunchTask": "buildproject",
"runtimeExecutable": "${execPath}",
"args": [
"--disable-extensions",
Copy link
Collaborator

@JD-Howard JD-Howard Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was handled in PR #160 and quite a bit more. Make sure you update to the latest before these test additions get added.

"--extensionDevelopmentPath=${workspaceFolder}",
"--extensionTestsPath=${workspaceFolder}/out/test/suite/index"
],
Expand Down
3 changes: 2 additions & 1 deletion extension/src/test/runTest.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,8 @@ async function main() {
try {
// The folder containing the Extension Manifest package.json
// Passed to `--extensionDevelopmentPath`
const extensionDevelopmentPath = path.resolve(__dirname, '../../../../');
// The __dirname is \AutoLispExt\out\test
const extensionDevelopmentPath = path.resolve(__dirname, '../../');
Copy link
Collaborator

@JD-Howard JD-Howard Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was handled in PR #160 and quite a bit more. Make sure you update to the latest before these test additions get added.

let extensionTestsPath ='';
// The path to the extension test or code coverage script
// Passed to --extensionTestsPath
Expand Down
Loading
Loading