Closed
Conversation
Sen-real
reviewed
May 12, 2021
| let msg = localize("autolispext.project.find.openproject", "A project must be open before you can search for a text string."); | ||
| vscode.window.showInformationMessage(msg); | ||
| return; | ||
| return Promise.reject(msg); |
Contributor
There was a problem hiding this comment.
what will happen in a real, manual use case?
Contributor
Author
There was a problem hiding this comment.
It will not happen on manual case. So later, I will delete the test cases.
Sen-real
reviewed
May 12, 2021
Comment on lines
+47
to
+53
| closeParenStyleStub = ImportMock.mockFunction(os, 'arch', 'x64'); | ||
| closeParenStyleStub = ImportMock.mockFunction(opt, 'getSearchOption', searchobj); | ||
| closeParenStyleStub = ImportMock.mockFunction(vscode.commands, 'executeCommand', mock_value); | ||
| closeParenStyleStub = ImportMock.mockFunction(opt, 'getString', "remove -layer"); | ||
| closeParenStyleStub = ImportMock.mockFunction(os, 'type', 'Darwin'); | ||
| closeParenStyleStub = ImportMock.mockFunction(fs, 'accessSync', null); | ||
| closeParenStyleStub = ImportMock.mockFunction(fs, 'chmodSync', null); |
Contributor
There was a problem hiding this comment.
please give each stub an identical name, and restore them all in suiteTeardown
Modify "return Promise.reject(msg)" to "return";
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
Contributor
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Add find/replace in project unit test cases
Abstractions
Src/project/findReplace folder contains the following tests:
Find in project
Open search result
Clear search result
Apply replacement in project
Replace in project
Find in file
Tests performed
Passed Local and Github tests
Screen shot