Repository navigation
Conversation
Every push to a PR built a prototype, though few PRs need one. A "Deploy Prototype Build?" input now gates the prototype step on PRs, which frees CI agents (AINFRA-3348). The input sits in a group so that it blocks only the prototype step. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Build Demo and the upload posted "Build Prototype" and "Publish Prototype" as pending while they waited for the input, and left them pending on every PR where nobody asked for a prototype. Build Demo keeps its "Build Prototype" status on trunk, where it runs without the input. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
| notify: | ||
| - github_commit_status: | ||
| context: "Build Prototype" |
There was a problem hiding this comment.
IIRC in the similar PR for another repo you removed the notify.github_commit_status from the step building the prototype on the justification that if you kept it it would be shown in GitHub PR's list of CI checks as pending. Which at the time made sense to me.
But looking at this PR, while the Prototype Build has not been triggered on it, while this step still has its notify block, I don't see any row for "Bulid Prototype" shown in there:
So I'm guessing that we'd only see that step if Buildkite actually starts this "Build Demo", which will only happen if someone clicked on the "Deploy Prototype Build?" first, and if nobody triggered a prototype build then "Build Prototype" row will not appear as a CI check row on the PR in GitHub, right?
If that's indeed how this works, then I'd suggest we keep the notify: [ github_commit_status: { context: … } ] nodes when doing those PRs, so that if no Prototype Build is triggered nothing is shown but if one is triggered then at least the progress of building that PB shows up in the GitHub PR's status checks.
| notify: | ||
| - github_commit_status: | ||
| context: "Publish Prototype" |
There was a problem hiding this comment.
In particular, if my understanding from above is correct, we should probably not remove those 3 lines.
Easy to check, btw: restore those lines then look if the row appears on GitHub even if you don't trigger a Prototype Build.
This branch has not been deployed
2 participants
Description
Each push to a PR builds the Demo app on a Mac and uploads it to Firebase App Distribution, though few PRs need it. This PR builds and uploads the Demo on PRs only when someone asks: a Deploy Prototype Build? button in the Buildkite build. Part of AINFRA-3348, which frees up the
macqueue. Pocket Casts iOS and Studio already work this way.trunk, the input is skipped, which Buildkite treats as satisfied, so the Demo still builds after every merge. Breakage in the Demo is caught there.github_commit_status. Buildkite posted those statuses as pending as soon as the steps waited for the input, which left "Build Prototype" and "Publish Prototype" pending on every PR where nobody asked for a prototype. Build Demo still posts "Build Prototype" ontrunk.publish_blocked_as_pending = false, so a PR build whose button is never clicked reports passed and blocked (success) to GitHub, not pending.Build Prototype is no longer a required status check on
trunk; a repo admin removed it for this change. PRs no longer post that check, and they no longer check that the Demo app compiles.trunkstill builds the Demo after every merge.Testing Steps
trunkbuild runs Build Demo without a prompt and posts "Build Prototype".🤖 Generated with Claude Code