Reset the position of the toolbar for compat with Gutenberg 15.7+#183
Open
Reset the position of the toolbar for compat with Gutenberg 15.7+#183
Conversation
Member
|
Thanks! Yeah, I've been sitting on a similar change for a while and was hoping to come up with something better, but fundamentally a change will be needed in Gutenberg to support it. I've put a similar change in Automattic/isolated-block-editor#230 and this will be included with #186 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #176
This switches the toolbar to be static-positioned on wp.org, so that it shows up above the post editor rather than floating outside it. It does remove the "fixed" aspect, if you write a long topic, the toolbar scrolls off screen.
This is really just a workaround for wordpress.org, so that we can unpin the version of Gutenberg — it doesn't do anything to fix the issue anywhere else the editor is used. This could be ported as a quick fix for other editors, or (more likely) it needs a better solution. So feel free to take or leave this PR 🙂