Open
Conversation
dd32
commented
Apr 18, 2024
| $tags['mark'] = [ 'class' => true ]; | ||
| $tags['sub'] = []; | ||
| $tags['sup'] = []; | ||
| $tags['span'] = [ 'style' => true ]; |
Member
Author
There was a problem hiding this comment.
Note: I'm fairly sure there's been some kses changes around having style validation, but I'm not sure if this is 100% safe without validating that functionality does actually exist.
Member
Author
|
It turns out that the underline isn't coming from core, but rather from the calypso editor, which I guess BE is based on somewhere in the chain, it's actually |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As reported in https://wordpress.org/support/topic/issue-with-underline-rendering-in-forum/ & https://meta.trac.wordpress.org/ticket/7599 certain styles are not being respected properly.
This PR adds the needed tags for Underline and Language selection.
Note: For WordPress.org I'm likely to remove some of these once I figure out how :)