fix: handle undefined head option in toString()#181
Open
ctonneslan wants to merge 1 commit intoAutomattic:v0.4.0from
Open
fix: handle undefined head option in toString()#181ctonneslan wants to merge 1 commit intoAutomattic:v0.4.0from
ctonneslan wants to merge 1 commit intoAutomattic:v0.4.0from
Conversation
When the Table constructor receives head: undefined, toString() crashes with 'Cannot read properties of undefined' because it tries to access .length on the undefined head value. Default to an empty array. Fixes Automattic#178
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes
toString()crashing when the Table constructor receiveshead: undefined.Problem
The
headvariable on line 89 takesoptions.headdirectly without defaulting, soundefinedpropagates to.lengthchecks on lines 92 and 95.Fix
Default
headto an empty array:options.head || []This matches the behavior when
headis not passed at all (the default options already sethead: []on line 48).Fixes #178